Closed
Bug 198247
Opened 21 years ago
Closed 19 years ago
In (Stub-)Installer builds, Download Manager "Del" key is not working (anymore)
Categories
(SeaMonkey :: Download & File Handling, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey1.0alpha
People
(Reporter: sgautherie, Assigned: ajschult784)
References
()
Details
(Keywords: fixed1.8, regression)
Attachments
(1 file)
3.09 KB,
patch
|
csthomas
:
review+
dveditz
:
superreview+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3) Gecko/20030312 Build Identifier: Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3) Gecko/20030312 Remembering my bug 166059 description "remove it, by keyboard ou menu button"; I would say that this bug is a _regression_, which happened after v1.1 and before v1.3. (I would guess nearer to v1.3, but I can't verify it myself.) Reproducible: Always Steps to Reproduce: 1. Open any page/file/URL, <about:> for example 2. 'Use Save Page As' on it 3a. The Download Manager opens [assuming you use it] 3b. The saved/downloaded file is highlighted Actual Results: The 'Del' key does not do anything; while the 'Remove from List' button does work. (== Workaround) Expected Results: 'Del' key should do the same job as the 'Remove from List' button.
Comment 1•21 years ago
|
||
@reporter Can you try a newer build ... does it have the same problem?
Reporter | ||
Comment 2•21 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030529] Bug still there, with v1.4rc1 and on W2K.
Comment 3•21 years ago
|
||
WFM: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030604
Comment 4•21 years ago
|
||
Does not WFM: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5a) Gecko/20030718 Possibly related: key_copy does not work with patch (attachment 129276 [details] [diff] [review]) from Bug 142798 comment 5.
Comment 6•21 years ago
|
||
*** Bug 209158 has been marked as a duplicate of this bug. ***
WFM on WinXP using BuildID 2003122208 I'm using a zipped version rather than an installer version, reporter (Serge), what sort of version are you using and on which platforms have you tested it? Same question to Jeff, Christian and Joe.
Comment 8•21 years ago
|
||
Was this bug valid before the new Download Manager perhaps? WFM also, with build 20031226, installer builds (0.8 branch).
Please note that this bug is in the Browser component, not Firebird. So yes, it was before the new Download manager. The Build ID from the original bug report says 1.3. I tested in 1.4 when I confirmed, and again just now in 1.6b. The bug exists.
Reporter | ||
Comment 10•21 years ago
|
||
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031208] (W98SE) Bug still there. Updating: *(OS) W95 -> W98, as I upgraded since :-> Re comment 7: Installed from <mozilla-win32-1.6b-installer.exe>.
OS: Windows 95 → Windows 98
Comment 11•20 years ago
|
||
*** Bug 241748 has been marked as a duplicate of this bug. ***
Comment 12•20 years ago
|
||
*** Bug 244354 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Browser → Seamonkey
Comment 13•20 years ago
|
||
Can reproduce with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041125.
Comment 14•20 years ago
|
||
Sorry, I don't see this either in my Linux trunk self-build or my Windows 2000 1.8a5 self-build; they both correctly delete the entry when I press Delete.
Reporter | ||
Comment 15•20 years ago
|
||
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.3) Gecko/20040910] (release) (W98SE) [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122] (release) (W98SE) Bug still there: tested again with a new profile from each too. Installed from <mozilla-win32-1.7.3-installer.exe> and <mozilla-win32-1.8a5-installer.exe>. Note: (confirming my initial comment) Using the menu (Alt-R or mouse) works, 'Del' key only has no effect: nothing in JS.C. nor in (Windows) Console.
Updated•20 years ago
|
Reporter | ||
Comment 16•20 years ago
|
||
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122] (release) (W98SE) Neil: I tried using VenkMan (with 2 breakpoints in <downloadmanager.js>): Alt-R works fine; Del seems to be ignored :-/ Then I tried to replace the line which you pointed out by {{ <key id="key_remove" key="Z" command="cmd_remove"/> }} hoping pressing the 'Z' key could work: ignored too. I'm clueless on how to debug this.
Comment 17•20 years ago
|
||
When you say 'Del' key, which 'Del' key do you mean? The one on the numeric keypad or the 'Delete' key above the cursor keys? When you tried 'Z' key did you try 'Shift' and 'z'?
Comment 18•20 years ago
|
||
(In reply to comment #17) >When you tried 'Z' key did you try 'Shift' and 'z'? Or you might need caps lock and z...
Comment 19•20 years ago
|
||
Alsro reproduced with Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.7.3) Gecko/20040910.
Updated•20 years ago
|
Assignee: firefox → download-manager
QA Contact: chrispetersen
Comment 20•20 years ago
|
||
*** Bug 200663 has been marked as a duplicate of this bug. ***
Keywords: regression
Comment 21•19 years ago
|
||
(In reply to comment #17) > When you say 'Del' key, which 'Del' key do you mean? The one on the numeric > keypad or the 'Delete' key above the cursor keys? For me neither of them works (of course, the one of the num pad with num lock disabled). I also tried to change the keyboard language to english (I usually use es-ES) to see if it's related, but it doesn't seem to be as it didn't worked. Bug still here with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050316.
Comment 22•19 years ago
|
||
Still here - Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a
Comment 23•19 years ago
|
||
Sorry for the previous comment (and the spam), it was incorrect and incomplete. The bug was not fixed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050625 but with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a it seems to be fixed.
Reporter | ||
Comment 24•19 years ago
|
||
(In reply to comment #23) > Mozilla/5.0 (Windows; U; Windows NT 5.0; > en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a it seems to be fixed. Maybe on your W2K, but not on my W98SE :-/ [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a] (release) (W98SE)
Reporter | ||
Comment 25•19 years ago
|
||
(In reply to comment #24) > Maybe on your W2K, but not on my W98SE :-/ Well, I was 50% true only: [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a] (release) (W98SE) Stub-Installer, SMv1.0a-release: bug present. [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050915 SeaMonkey/1.1a] (nightly) (W98SE) Zip, SMv1.0a-release or SMv1.1a-nighly: no bug (= "fixed"). Then this may be "installer" related, as Ian asked before...
Reporter | ||
Comment 26•19 years ago
|
||
(In reply to comment #25) > Then this may be "installer" related, as Ian asked before... I compared Stub-I and Zip SMv1.0a, and was lucky enough to find the cause right away: the Stub-I installed bits miss {{ <RDF:Seq RDF:about="chrome://communicator/content/downloadmanager/downloadmanager.xul"> <RDF:li>chrome://communicator/content/tasksOverlay.xul</RDF:li> <RDF:li>chrome://communicator/content/utilityOverlay.xul</RDF:li> </RDF:Seq> }} in <overlays.rdf> ! (which explains everything :->) Who knows how to fix this ? Neil !? ;-)
Flags: blocking-seamonkey1.0b?
Summary: "Del" key is not working (anymore) in Download Manager → In (Stub-)Installer builds, Download Manager "Del" key is not working (anymore)
Apparently Mozilla shipped with this based on its age, so not blocking.
Flags: blocking-seamonkey1.0b? → blocking-seamonkey1.0b-
Reporter | ||
Comment 28•19 years ago
|
||
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050910 SeaMonkey/1.0a] (release) (W98SE) Same bug in Full-I and Stub-I versions.
<RDF:Seq RDF:about="chrome://communicator/content/downloadmanager/downloadmanager.xul"> <RDF:li>chrome://communicator/content/tasksOverlay.xul</RDF:li> <RDF:li>chrome://communicator/content/utilityOverlay.xul</RDF:li> </RDF:Seq> This appears only in the zip's overlays.rdf. The zip vs installer overlays.rdf are otherwise identical (after you undo the different ordering).
Pointing the installer build at the zip build's profile (I kept them separate) did not make the installer build work. Deleting the overlays.rdf caused both the zip build and the installer build to not do anything when I pressed delete. No overlays.rdf was regenerated in the install directories. Putting the overlays.rdf files back caused the zip build to work again.
Comment 31•19 years ago
|
||
I think I can guess what's going on here now - browser.jst isn't registering the downloadmanager chrome, so it probably needs an extra line like this: registerChrome(CONTENT | DELAYED_CHROME, getFolder("Chrome","comm.jar"),"content/communicator/downloadmanager");
Assignee | ||
Comment 32•19 years ago
|
||
patch based on comment 31. I can't verify that this helps because the bug doesn't affect linux. The installer just runs regchrome when it's done installing files.
Assignee: download-manager → ajschult
Status: NEW → ASSIGNED
Attachment #196534 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•19 years ago
|
Attachment #196534 -
Flags: superreview?(dveditz)
Attachment #196534 -
Flags: review?(neil.parkwaycc.co.uk)
Attachment #196534 -
Flags: review?(cst)
I don't think the patch helped.
Comment on attachment 196534 [details] [diff] [review] patch As far as I can tell, this had no effect (or had a negative effect?). After install, there is no overlays.rdf until the browser runs once, at which point it's autogenerated but still doesn't have anything download-related.
Attachment #196534 -
Flags: review?(cst) → review-
Reporter | ||
Comment 35•19 years ago
|
||
I just wanted to quote this, without knowing which browser.jst does what... <http://lxr.mozilla.org/mozilla/find?string=browser.jst> {{ /browser/installer/windows/browser.jst /browser/installer/unix/browser.jst /calendar/installer/windows/browser.jst /xpinstall/packager/build/win/mozilla/XPI_JSTs/browser.jst /xpinstall/packager/mac/browser.jst /xpinstall/packager/os2/browser.jst /xpinstall/packager/unix/browser.jst /xpinstall/packager/windows/browser.jst }}
Comment on attachment 196534 [details] [diff] [review] patch + registerChrome(CONTENT | DELAYED_CHROME, getFolder("Chrome","comm.jar"),"content/communicator/downloadmanager"); r=me with trailing slash
Attachment #196534 -
Flags: review- → review+
Comment 37•19 years ago
|
||
Comment on attachment 196534 [details] [diff] [review] patch sr=dveditz As cst noted, the windows version needs a trailing slash
Attachment #196534 -
Flags: superreview?(dveditz) → superreview+
Assignee | ||
Comment 38•19 years ago
|
||
landed on trunk. Can someone verify this fixed the problem with tomorrow's build and I'll request approval.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
(In reply to comment #38) > landed on trunk. > Can someone verify this fixed the problem with tomorrow's build and I'll request > approval. Verified FIXED using trunk SeaMonkey 1.1a Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050927 Mozilla/1.0
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 40•19 years ago
|
||
Comment on attachment 196534 [details] [diff] [review] patch super-low risk, SeaMonkey-only.
Attachment #196534 -
Flags: approval1.8b5?
Updated•19 years ago
|
Attachment #196534 -
Flags: approval1.8b5? → approval1.8b5+
Keywords: fixed1.8
Checked in on branch, if my previous change didn't make that obvious :).
Reporter | ||
Comment 42•19 years ago
|
||
(In reply to comment #39) > Verified FIXED using trunk SeaMonkey 1.1a [Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20050928 SeaMonkey/1.1a] (nightly) (W98SE) Confirming (with Full Installer), as bug reporter.
Target Milestone: --- → Seamonkey1.0alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•