198794 - Non-portable multi-character literals in "nsExternalHelperAppService"

Status: VERIFIED DUPLICATE of bug 120045

(Core :: Networking, defect)

Description

[Nils Hammar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030210
Build Identifier: Mozilla/5.0 Attempted build of 1.3 under HP-UX

The following warnings occurs while attempting a build under HP-UX 11.00/32.

Warning 728: "nsExternalHelperAppService.cpp", line 108 # Multicharacter charact
er literals are not portable.
      { TEXT_PLAIN, "txt,text", "Text File", 'TEXT', 'ttxt' },
                                             ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 108 # Multicharacter charact
er literals are not portable.
      { TEXT_PLAIN, "txt,text", "Text File", 'TEXT', 'ttxt' },
                                                     ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 109 # Multicharacter charact
er literals are not portable.
    TEXT_HTML, "html,htm,shtml,ehtml", "HyperText Markup Language", 'TEXT', 'MOS
S' },
                                                                    ^^^^^^

Warning 728: "nsExternalHelperAppService.cpp", line 109 # Multicharacter charact
er literals are not portable.
    L, "html,htm,shtml,ehtml", "HyperText Markup Language", 'TEXT', 'MOSS' },
                                                                    ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 110 # Multicharacter charact
er literals are not portable.
      { TEXT_RDF, "rdf", "Resource Description Framework", 'TEXT','ttxt' },
                                                           ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 110 # Multicharacter charact
er literals are not portable.
      { TEXT_RDF, "rdf", "Resource Description Framework", 'TEXT','ttxt' },
                                                                  ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 111 # Multicharacter charact
er literals are not portable.
      { TEXT_XUL, "xul", "XML-Based User Interface Language", 'TEXT', 'ttxt' },
                                                              ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 111 # Multicharacter charact
er literals are not portable.
    { TEXT_XUL, "xul", "XML-Based User Interface Language", 'TEXT', 'ttxt' },
                                                                    ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 112 # Multicharacter charact
er literals are not portable.
    TEXT_XML,          "xml,xsl,xbl", "Extensible Markup Language", 'TEXT', 'ttx
t' },
                                                                    ^^^^^^

Warning 728: "nsExternalHelperAppService.cpp", line 112 # Multicharacter charact
er literals are not portable.
    ,          "xml,xsl,xbl", "Extensible Markup Language", 'TEXT', 'ttxt' },
                                                                    ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 113 # Multicharacter charact
er literals are not portable.
    html+xml", "xhtml,xht", "Extensible HyperText Markup Language", 'TEXT', 'ttx
t' },
                                                                    ^^^^^^

Warning 728: "nsExternalHelperAppService.cpp", line 113 # Multicharacter charact
er literals are not portable.
    ", "xhtml,xht", "Extensible HyperText Markup Language", 'TEXT', 'ttxt' },
                                                                    ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 117 # Multicharacter charact
er literals are not portable.
      { TEXT_CSS, "css", "Style Sheet", 'TEXT', 'ttxt' },
                                        ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 117 # Multicharacter charact
er literals are not portable.
      { TEXT_CSS, "css", "Style Sheet", 'TEXT', 'ttxt' },
                                                ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 118 # Multicharacter charact
er literals are not portable.
      { APPLICATION_JAVASCRIPT, "js", "Javascript Source File", 'TEXT', 'ttxt' }
,
                                                                ^^^^^^

Warning 728: "nsExternalHelperAppService.cpp", line 118 # Multicharacter charact
er literals are not portable.
    APPLICATION_JAVASCRIPT, "js", "Javascript Source File", 'TEXT', 'ttxt' },
                                                                    ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 119 # Multicharacter charact
er literals are not portable.
      { MESSAGE_RFC822, "eml", "RFC-822 data", 'TEXT', 'MOSS' },
                                               ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 119 # Multicharacter charact
er literals are not portable.
      { MESSAGE_RFC822, "eml", "RFC-822 data", 'TEXT', 'MOSS' },
                                                       ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 128 # Multicharacter charact
er literals are not portable.
      { APPLICATION_XPINSTALL, "xpi", "XPInstall Install", 'xpi*','MOSS' },
                                                           ^^^^^^
Warning 728: "nsExternalHelperAppService.cpp", line 128 # Multicharacter charact
er literals are not portable.
      { APPLICATION_XPINSTALL, "xpi", "XPInstall Install", 'xpi*','MOSS' },
                                                                  ^^^^^^



Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[hacker formerly known as [e-mail]]

-> uriloader

Comment 2

[hacker formerly known as [e-mail]]

-> bz

Comment 3

[Boris Zbarsky [:bzbarsky]]

They don't need to be portable -- they're only used in Mac code.  What _should_ 
happen is that we should not even build them on non-Mac platforms...

*** This bug has been marked as a duplicate of 120045 ***

Comment 4

[benc]

VERFIFIED/dupe.