198823 - Should be able to set Default Character Coding in Preferences dialog

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Koike Kazuhiko]

Preferences dialog for ChatZilla should have "Default Character Coding"
item, like Navigator and Mail.

Comment 1

[Koike Kazuhiko]

Attachment: patch v1

Comment 2

[Koike Kazuhiko]

Comment on attachment 118180 [details] [diff] [review]
patch v1

If you launch Mozilla with "-chat" and open the preferences dialog, the
menulist can't load any item. Otherwise this patch works fine.

Comment 3

[Prognathous]

Koike Kazuhiko, how about fixing the patch so that this might land in 1.4/final?

Prog.

Comment 4

[Robert Ginda]

Comment on attachment 118180 [details] [diff] [review]
patch v1

included in next xpi

Comment 5

[Robert Ginda]

marking fixed, 0.8.34 checked in.

Comment 6

[Koike Kazuhiko]

Attachment: patch v2

menulist is always empty now.

Comment 7

[Koike Kazuhiko]

Reopening bug.

Comment 8

[Alex Vincent [:WeirdAl]]

*** Bug 212545 has been marked as a duplicate of this bug. ***

Comment 9

[Alex Vincent [:WeirdAl]]

kazhik: unofficial r+ on your patch.  It was effectively the same solution I
proposed for bug 212545.  (I'm not a reviewer on anything, but this one's so
obvious.)

Comment 10

[Robert Ginda]

added to 0.9.7

Comment 11

[Robert Ginda]

The chatzilla 0.9.x branch has landed on the trunk and should be available in
tomorrow's nightly build.  If you believe this bug has not actually been fixed,
please repoen it.

Comment 12

[Mike Kaply [:mkaply]]

Since this affects L10N, we can't take it for 1.4.

Comment 13

[Andreas Kunz]

Comment on attachment 126860 [details] [diff] [review]
patch v2

Removing obsolete review request.