198895 - nsPluginTag::RegisterWithCategoryManager leaks pref service

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsPluginTag::RegisterWithCategoryManager holds on to the pref service forever,
even though it has no need to do so.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 198899 has been marked as a duplicate of this bug. ***

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 118254 [details] [diff] [review]
patch

sr=bryner

Comment 4

[Peter Lubczynski]

Comment on attachment 118254 [details] [diff] [review]
patch

r=peterl

Comment 5

[Alec Flett]

Comment on attachment 118254 [details] [diff] [review]
patch

nice! This has been driving me nuts, and I couldn't figure out where it was
coming from!
sr=alecf

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-03-25 06:55 PST.

Comment 7

[bmartin]

Verified that the changes reflected in the attached patch were checked in on
03/25/03

CVS Log:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp

Rev details:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsPluginHostImpl.cpp&root=/cvsroot&subdir=mozilla/modules/plugin/base/src&command=DIFF_FRAMESET&rev1=1.468&rev2=1.469