199920 - remove remaining mozilla/include headers

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[hacker formerly known as [e-mail]]

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

this would also fix bug 173634, right?

Comment 2

[hacker formerly known as [e-mail]]

It would fix the original summary for bug 173634 but I'm not sure what it
morphed into.

Comment 3

[hacker formerly known as [e-mail]]

Attachment: v1.0 (checked in)

* Move XP_IS_ macros into nsCRT.h & rename them to NS_IS_
* Make local XP_IS_ macros use the nsCRT ones
* Remove NOT_NULL defines

Comment 4

[Alec Flett]

Comment on attachment 118968 [details] [diff] [review]
v1.0 (checked in)

yee haw! Nice job chris. So good to see these things gone.

Comment 5

[hacker formerly known as [e-mail]]

Attachment: remove include/ from build

When the patches from bug 171883 land, this can be checked in and everything in
mozilla/include can be cvs removed.

Comment 6

[Malcolm Rowe]

Comment on attachment 118968 [details] [diff] [review]
v1.0 (checked in)

Just some notes on the patch, if anyone cares:

1. The lines at
http://lxr.mozilla.org/seamonkey/source/mailnews/base/public/msgCore.h#87 

Now read:
 87 #if defined(XP_WIN) || defined(XP_OS2)
 88 #define IS_ALPHA(VAL) NS_IS_ALPHA(VAL)
 89 #else
 90 #define IS_ALPHA(VAL) NS_IS_ALPHA(VAL)
 91 #endif

.. which seems a little redundant to me.

2. Should the define for the first NS_IS_ALPHA variant in nsCRT.h be #ifdef
XP_WIN || XP_OS2, to match what was taken from msgCore.h?

Comment 7

[hacker formerly known as [e-mail]]

1. I know.  Didn't seem like it was worth redoing the patch to fix.
2. Nice catch.

Comment 8

[hacker formerly known as [e-mail]]

mozilla/include has been removed from the build sytsem and cvs removed.