200236 - Change Master password dialog OK button disabled with matching passwords

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Ken Takusagawa]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030401
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030401

When selecting a Master password for the first time, the OK button is
grayed-out even after entering matching passwords.

Slightly weirder is that after entering matching passwords, hitting
the HOME button in the second password prompt enables the OK button.

The above URL triggers the Change Master Password, but only works for MIT 
students (sorry).  I doubt it is a problem specific to the site.


Reproducible: Always

Steps to Reproduce:
1. Go to a site that stores does certificates or somehow triggers the 
Change Master Password Dialog.
2. Enter two matching passwords, using TAB to switch between the prompts


Actual Results:  
OK button grayed out

Expected Results:  
OK button not grayed out.

Works fine in 1.3

Comment 1

[Kai Engert (:KaiE:)]

Confirming. This looks seriously broken.

Comment 2

[Kai Engert (:KaiE:)]

It works correctly with 1.3, regression.
I don't see *any* checkin to the security UI code after the date where the trunk
branched for 1.3, so it seems very likely something else in Mozilla caused this
new behaviour as a side effect.

Comment 3

[Kai Engert (:KaiE:)]

It seems that onkeypress events are now handled differently.
It seems, in the past the onkeypress handler was called *after* the key arrived
in a text field.
Now it seems, the onkeypress handler gets called *before* the key arrives.

This breaks the behaviour of this dialog, because it expects to be called after.

I found a workaround. By not using onkeypress, but using oninput the dialog
appears to work again. I'll attach a patch.

cc'ing bryner, aroonl, jkeiser. Timeless said, you might have changed the
behaviour? Since I have a workaround, no action is necessary, but cc'ing you
anyway, in case you changed the behaviour accidentially.

Comment 4

[Kai Engert (:KaiE:)]

Attachment: Patch v1

Comment 5

[Kai Engert (:KaiE:)]

Comment on attachment 119971 [details] [diff] [review]
Patch v1

Javi, can you please review?

Comment 6

[Kai Engert (:KaiE:)]

Nominating as a blocker for 1.4 beta.

Comment 7

[Javier Delgadillo]

Comment on attachment 119971 [details] [diff] [review]
Patch v1

r=javi

Comment 8

[Kai Engert (:KaiE:)]

Comment on attachment 119971 [details] [diff] [review]
Patch v1

Alec, can you please review this tiny patch?

Comment 9

[Alec Flett]

Comment on attachment 119971 [details] [diff] [review]
Patch v1

sr=alecf

Comment 10

[Kai Engert (:KaiE:)]

checked in, fixed

Comment 11

[Kai Engert (:KaiE:)]

*** Bug 203538 has been marked as a duplicate of this bug. ***

Comment 12

[John Unruh]

Verified.