Closed
Bug 200528
Opened 21 years ago
Closed 21 years ago
ldap/include/portable.h is confused about Solaris
Categories
(Directory :: LDAP C SDK, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
5.12
People
(Reporter: mcs, Assigned: mcs)
Details
Attachments
(2 files)
3.73 KB,
patch
|
Details | Diff | Splinter Review | |
937 bytes,
patch
|
Details | Diff | Splinter Review |
Thanks to a hint from Saul, I discovered that there are tests like this in portable.h but sunos5 is not defined: #if defined(sunos5) ... As it turns out, most of these are not causing harm in the current (trunk) code. But this should be cleaned. up.
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → 5.13
Assignee | ||
Comment 1•21 years ago
|
||
Removed all occurrences of sunos5. We no longer provide defines for these things at all (they are not used anywhere): HAVE_GETPWNAM_R HAVE_GETGRNAM_R SIG_FN WAIT_FLAGS
Comment 2•21 years ago
|
||
OK.
Updated•21 years ago
|
QA Contact: nobody
Assignee | ||
Comment 3•21 years ago
|
||
Fix committed to the trunk: mozilla/directory/c-sdk/ldap/include/portable.h new revision: 5.8; previous revision: 5.7 Fix 200528 - ldap/include/portable.h is confused about Solaris. Avoid using sunos5 (not defined). Removed definitions of these macros that are not used anwhere: HAVE_GETPWNAM_R, HAVE_GETGRNAM_R, SIG_FN, WAIT_FLAGS.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•21 years ago
|
||
I had to back out part of the fix... older Linux releases do not define in_addr_t.
Assignee | ||
Comment 6•21 years ago
|
||
fix for the fix committed to the trunk: mozilla/directory/c-sdk/ldap/include/portable.h new revision: 5.9; previous revision: 5.8 Follow up fix for 200528 - ldap/include/portable.h is confused about Solaris: older Linux versions do not have in_addr_t, so don't assume they do.
You need to log in
before you can comment on or make changes to this bug.
Description
•