2010 - {css1} ugly border edges at line breaks

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The edges of borders on inline elements are ugly at line breaks.  They have
diagonal ends.

Comment 1

[kipp]

troy, could you fix this one? It's probably not too bad - the information about
which edges are being skipped is available and could be passed used to do a
better job at rendering...if not, then punt it over to sparky.

Comment 2

[troy]

Michael, I would do this but I think the border code is at the point where it
needs a restructuring. The way MakeSide() is now there are already three cases
per-side (plus the check for one-pixel lines). To add checks and handle the case
for drawing the bevel means duplicating logic many times

Comment 3

[leger]

Setting all current Open/Normal to M4.

Comment 4

[rubydoo123]

setting ChrisD as qa

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I have a fix for this, which I emailed it to kmcclusk.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 7126 has been marked as a duplicate of this bug. ***

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch that fixes bug

Comment 8

[Kevin McCluskey (gone)]

Applied patch in July 27, 1999 5:03PM build.
Verified that it does fix the beveled line endings.
Also viewed CSS1 border test suite.

Comment 9

[Christine Hoffman]

Using 8/2 Apprunner, border edges at line breaks look okay. Verifying bug fixed.

Comment 10

[Hixie (not reading bugmail)]

Migrating from {css1} to css1 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...