201355 - footprint improvments in embedding/components/windowwatcher

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Andrew Taylor]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030401
Build Identifier: 

There are a few constant strings in embedding/components/windowwatcher that can
be changed from pointers to char arrays to save on footprint.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Andrew Taylor]

Attachment: Makes constant strings character arrays rather than pointers

This patch makes the constant strings character arrays, saving a whole 32 bytes
of .data.  It also gets rid of 5 relocations.

Comment 2

[Alec Flett]

Comment on attachment 119976 [details] [diff] [review]
Makes constant strings character arrays rather than pointers

more great cleanup! sr=alecf

Comment 3

[Alec Flett]

this is your bug now :)
(I'm confirming your bugzilla account so you can do this yourself..)

Comment 4

[Adam Lock]

Comment on attachment 119976 [details] [diff] [review]
Makes constant strings character arrays rather than pointers

r=adamlock

Do we have a doc somewhere which talks about this issue? I'm just curious since
I tend to use char * consts when it seems to be a bad thing.

Comment 5

[Alec Flett]

adam: I posted to netscape.public.mozilla.performance about this.. as a general
rule you should use const char foo[] = "..."; rather than const char*

Comment 6

[Boris Zbarsky [:bzbarsky]]

Patch checked in, per Andrew's request.  If there is nothing else remaining to
do, please mark fixed.

Comment 7

[Andrew Taylor]

This is checked in so I'm marking it as fixed.

Comment 8

[Charles Rosendahl]

Verified in code