Closed
Bug 201400
Opened 21 years ago
Closed 21 years ago
add getter and observer for browse with caret to event state manager
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
People
(Reporter: Brade, Assigned: Brade)
References
Details
Attachments
(1 file, 1 obsolete file)
4.63 KB,
patch
|
sfraser_bugs
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
Event State Manager (which has mBrowseWithCaret) needs a getter so it can be queried for and not just toggled.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Comment 2•21 years ago
|
||
Comment on attachment 120005 [details] [diff] [review] patch based on conversation with aaronl Aaron--I haven't tested this yet (I need a clean tree to test it on); could you do a conditional review (conditional that it not break anything)?
Attachment #120005 -
Flags: review?(aaronl)
Comment 3•21 years ago
|
||
Comment on attachment 120005 [details] [diff] [review] patch based on conversation with aaronl r=aaronl as long as it doesn't break anything :) Also, once you eliminate ResetBrowseWithCaret() from nsDOMWindowController, it can be removed from nsIEventStateManager and be turned into a helper: void ResetBrowseWithCaret(void)
Attachment #120005 -
Flags: review?(aaronl) → review+
Comment 4•21 years ago
|
||
Attachment #120005 -
Attachment is obsolete: true
Comment 5•21 years ago
|
||
Comment on attachment 120270 [details] [diff] [review] Tweaked version of the patch, doesn't crash. Moving r= forward, sr=me
Attachment #120270 -
Flags: superreview+
Attachment #120270 -
Flags: review+
Comment 6•21 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Depends on: 906281
Updated•5 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•