202086 - Move atk specific code from xp dir to accessible/src/atk

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Kyle Yuan]

this is a followup to bug 199060.

Comment 1

[Kyle Yuan]

Attachment: patch

1. move atk specific idl files into public/atk
2. create some atk specific wrapped accessible classes in src/atk
3. remove #ifdef MOZ_ACCESSIBILITY_ATK/#endif block as more as possible

the patch looks huge just because I moved a lot of code around ;-)

Comment 2

[Kyle Yuan]

Comment on attachment 120799 [details] [diff] [review]
patch

Aaron, still have time to take a look?

Comment 3

[Aaron Leventhal]

Comment on attachment 120799 [details] [diff] [review]
patch

No time to look, can you get r= from within your own team?

Comment 4

[Kyle Yuan]

Comment on attachment 120799 [details] [diff] [review]
patch

okay, over to bolian...

Comment 5

[Aaron Leventhal]

Comment on attachment 120799 [details] [diff] [review]
patch

r=aaronl

Hi Kyle. I had time to look at it. I see that this does not yet move any
widget/src/gtk2/mai code over.

Looks good.

Comment 6

[Aaron Leventhal]

Kyle, if you want you can ask Leaf to do a cvs rename of files that are just
moving. That way you can keep the cvs history for those files.

Note to superreviewer, none of this is new code. It's just being moved around.

Comment 7

[Kyle Yuan]

Comment on attachment 120799 [details] [diff] [review]
patch

thanks, Aaron. the mai's moving is in another bug 202085.

Comment 8

[Henry Jia]

Comment on attachment 120799 [details] [diff] [review]
patch

Looks good.

sr=Henry

Comment 9

[Kyle Yuan]

checked in! 

sorry, Aaron, you have to update your local tree, my patch touched over 50 
files.