202218 - [beos] customize toolbar window displays titlebar

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Paul]

I have a patch prepared for the BeOS widget library, that makes nsWindow under
BeOS honor the eBorderStyle attributes of a window.  I wrote the patch, in the
hopes that the "Customize Toolbar" window would be created w/o the title bar.

However, the title bar remains.  The eBorderStyle that is passed into the
nsWindow's create method is eBorderStyle_all, so, even with my patch applied,
the window still has a titlebar. 

I've searched for where and why this is happenning, but, I'm having trouble
finding the solution.

Comment 1

[Paul]

Some addition comments:

Is it the intension of Phoenix that eWindowType_dialog has no titlebar, is not
resizable, etc.?  The reason I ask, is that the "Customize Toolbar" window is
created as a dialog, and, with a border style of eWindowStyle_default, which is,
according to nsIWidget.h:

  // whatever the OS wants... i.e. don't do anything
  eBorderStyle_default  = -1

But, obviously, that is not what I suspect is suposed to happen.  So, shouldn't
the border style for the custimize toolbar dialog be eBorderStyle_none instead?
 If so, where would this be defined?

Comment 2

[Paul]

Setting to major, as, IMO, the customize toolbar item is fairly significant in
Firebird, and, with the way things work now, not only is it ugly, but completely
wrong.
Setting P1, since I would like to get this fixed ASAP.

Comment 3

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 4

[Mike Connor [:mconnor]]

not major severity, please don't set priority on bugs, that is a assignee-set flag

Comment 5

[Mike Kaply [:mkaply]]

The customize toolbar window actually appears to use the function HideWindowChrome.

You need to implement this function on BeOS.

Comment 6

[tqh]

/* Hide window chrome (borders, buttons) for this widget. */

Which means we should override it and change style of the window where there is one.

Should be easy to do. 

Comment 7

[tqh]

Implementing HideWindowChrome doesn't seem to do that. Maybe that's called in a
specific OS implementation?

Comment 8

[Sergei Dolgov]

tqh,
in our case it needs changing BWindow look, did you try to do it?

Comment 9

[tqh]

Fixed by bug 296856.