20232 - Replace T::GetIID() (etc.) with NS_GET_IID(T)

Status: RESOLVED INCOMPLETE

(Core :: XPCOM, defect, P3)

Description

[Suresh Duddi (gone)]

Here is pierre's patch to converting usage of IID to NS_GET_IID()

Comment 1

[Suresh Duddi (gone)]

Attachment: NS_GET_IID() conversion

Comment 2

[Suresh Duddi (gone)]

Patch checked in.

Comment 3

[Pierre Phaneuf]

Little misunderstanding: this is going to be mozilla-wide, not localized to
XPCOM! I am doing this progressively, one patch at a time though...

Comment 4

[Pierre Phaneuf]

Attachment: NS_GET_IID and NS_DEFINE_IID work in mozilla/view

Comment 5

[Suresh Duddi (gone)]

scc, do you think it might make sense to get pierre checking priviledge for
this.

Comment 6

[Pierre Phaneuf]

Looking for somebody to review and check in the submitted patch.

Comment 7

[Pierre Phaneuf]

Attachment: NS_GET_IID and NS_DEFINE_IID work in mozilla/silentdl

Comment 8

[Suresh Duddi (gone)]

Moving to M13 as this isn't M12 critical

Comment 9

[Pierre Phaneuf]

Attachment: Compressed diff of more NS_GET_IID and NS_DEFINE_IID work.

Comment 10

[Pierre Phaneuf]

This can wait for M14, no need to block M13 for this.

Comment 11

[Pierre Phaneuf]

This shouldn't block a release, it is more of an improvement than a critical
fix.

Comment 12

[K Carter]

Last couple of diffs never seemed to have been checked in?  Is this work still 
ongoing?

Comment 13

[Dawn Endico]

dp is no longer @netscape.com. changing qa contact to default for this product

Comment 14

[Matthias Versen [:Matti]]

[e-mail]/[e-mail] :
Are you working on this or can we close this bug ?

Comment 15

[Pierre Phaneuf]

I'm not working on this, sorry, no time. Not fixed, but LATER.

Comment 16

[Christopher Hoess (gone)]

LATEr is deprecated.

Comment 17

[timeless]

Attachment: witch hunt

it seems mcsmurf has been running with this patch for a while :)

Comment 18

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 234828 [details] [diff] [review]
witch hunt

+NS_IMPL_ISUPPORTS2(nsIRenderingContext,
+                   nsIRenderingContextOS2)

needs to have an nsRenderingContextOS2 as the first argument


sr=biesi with that fixed

Comment 19

[timeless]

Comment on attachment 234828 [details] [diff] [review]
witch hunt

mozilla/gfx/src/os2/nsRenderingContextOS2.cpp 	1.97
mozilla/mailnews/local/src/nsMailboxUrl.cpp 	1.98
mozilla/modules/plugin/samples/SanePlugin/nsSanePlugin.cpp 	1.16
mozilla/content/xtf/src/nsXMLContentBuilder.cpp 	1.9
mozilla/modules/oji/tests/src/TestLoader/OJITestLoaderFactory.cpp 	1.9
mozilla/embedding/browser/gtk/src/EmbedPrivate.cpp 	1.64
mozilla/embedding/browser/photon/src/EmbedPrivate.cpp 	1.30
mozilla/xpcom/io/nsDirectoryService.cpp 	1.89
mozilla/embedding/browser/qt/src/qgeckoembed.cpp 	1.4
mozilla/security/manager/ssl/src/nsCertTree.cpp 	1.50
mozilla/security/manager/ssl/src/nsCertTree.cpp 	1.51
mozilla/security/manager/ssl/src/nsNSSCertificate.cpp 	1.122
mozilla/mailnews/news/src/nsNewsFolder.cpp 	1.272

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Note that many of the places you're fixing here would be even better of if they were fixed as described in bug 342595.

Comment 21

[Benjamin Smedberg]

I think most of this got fixed with table-driven QI