Closed Bug 202606 Opened 21 years ago Closed 21 years ago

Need a way to disable showing of bitmap in dialog

Categories

(Core Graveyard :: Installer: GRE, defect)

Product:
Core Graveyard
Component:
Installer: GRE
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: ssu0262, Assigned: ssu0262)

References

Details

(Whiteboard: [adt2])

Attachments

(1 file, 3 obsolete files)

patch v1.2.1
105.83 KB, patch
dmosedale
: superreview+
asa
: approval1.4b+
Details | Diff | Splinter Review 
In the GRE installer, the download and install process dialogs have a bitmap
banner image that needs to be hidden via a cmdline arg and config.ini preference.

This is a place holder bug for bugscape bug:
  http://bugscape.mcom.com/show_bug.cgi?id=22333
setting status and keyword to complement the bugscape bug.
Status: NEW → ASSIGNED
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt2]
Attached patch patch v1.0 (obsolete) — — Splinter Review 
This patch happens to fix a few things:
 * adds cmdline arg and config.ini pref to control showing of the download and
   install progess dialogs
 * going between dialogs rembers the last dialog position so the next dialog
   will be shown in the position of the last dialog.
 * going between dialogs (specially in dialogs that show automatically) no
   longer creates the next dialog to show ontop of all other dialogs.
   This is helpful when user has other dialogs ontop of the installer dialog
   and the installer dialog automatically shows a dialog.  It's non intrusive
   now.
 * setup.exe -h (usage) now works again.
Attachment #121040 - Flags: review?(dveditz)
Attachment #121040 - Attachment is obsolete: true
Attachment #121040 - Flags: review?(dveditz)
Attached patch patch v1.1 (obsolete) — — Splinter Review 
updated patch contains the following fixes:
 * added more comments to how new functions work
 * cleaned up MoveDlgItem
 * renamed some new functions to be more mnemonic
 * cleaned up a couple of redundant global vars that were left.
 * generalized the way CR is added to .ini strings.
Attachment #121251 - Flags: review?(sgehani)
Attached patch patch v1.2 (obsolete) — — Splinter Review 
minor fixes after talking with sgehani.
Attachment #121251 - Attachment is obsolete: true
Attachment #121251 - Attachment is obsolete: false
Attachment #121251 - Flags: review?(sgehani)
Attachment #121251 - Attachment is obsolete: true
Attachment #121314 - Flags: review+
Attachment #121314 - Flags: superreview?(dveditz)
Attached patch patch v1.2.1 — — Splinter Review 
Forgot to diff the setuprsc dir in the previous patch.	Nothing has else
changed from the review by sgehani.
Attachment #121314 - Attachment is obsolete: true
Attachment #121314 - Flags: superreview?(dveditz)
Attachment #121354 - Flags: superreview?(dveditz)
Comment on attachment 121354 [details] [diff] [review]
patch v1.2.1

rs=dmose@mozilla.org
Attachment #121354 - Flags: superreview?(dveditz) → superreview+
this bug fixes several problems (see comment #2).  The look and feel of the
installer would be improved.  The -h fix would help mozilla users figure out how
to control the installers without resorting to looking at and modifying it's
config.ini.  This fix is not risky for 1.4b.
Flags: blocking1.4b?
Flags: blocking1.4b?
Attachment #121354 - Flags: approval1.4b?
Comment on attachment 121354 [details] [diff] [review]
patch v1.2.1

a=asa (on behalf of drivers) for checkin to 1.4b.
Attachment #121354 - Flags: approval1.4b? → approval1.4b+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
reopening.  patch was backed out due to bug 203194.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 203194
patch checked in again.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
v.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: