Closed
Bug 203443
Opened 21 years ago
Closed 21 years ago
main program icon doesnt get pulled in properly with MingW builds
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.5beta
People
(Reporter: jonwil, Assigned: jag+mozilla)
References
Details
Attachments
(1 file)
4.40 KB,
patch
|
leaf
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
Windres doesnt say anything so I dont know why its not being pulled into the program properly.
Comment 1•21 years ago
|
||
I'd noticed this, but had assumed it had something to do with my building/running problems. Seems I was wrong.
Comment 2•21 years ago
|
||
-> build config, at a guess
Assignee: asa → mozbugs-build
Component: Browser-General → Build Config
QA Contact: asa → granrose
-> XP Apps
Assignee: mozbugs-build → jaggernaut
Component: Build Config → XP Apps
QA Contact: granrose → paw
Comment 4•21 years ago
|
||
*** Bug 211794 has been marked as a duplicate of this bug. ***
Comment 5•21 years ago
|
||
If this is a WINDRES issue, which I'm not sure about, wasn't there going to be a new release of WINDRES a while back?
Comment 6•21 years ago
|
||
Opened my MingW compiled mozilla.exe in Resource Hacker, and nothing appears.
Comment 7•21 years ago
|
||
The compiled resource file (whatever.res) is not being included when the program is linked, and therefore is not being included in the compiled executables. The flag -mwindows should also be added so the programs are compiled as true Windows programs (a console window won't appear when the program is run). I've verified these both myself by re-building mozilla.exe by hand (just modifying the command make uses), but don't have the time to change the build system myself.
Comment 8•21 years ago
|
||
I do hope this gets fixed soon, as it's somewhat annoying not havng an icon in my builds.
Attachment #128793 -
Flags: superreview?(bryner)
Attachment #128793 -
Flags: review?(leaf)
Comment 10•21 years ago
|
||
Comment on attachment 128793 [details] [diff] [review] v1.0 r=leaf
Attachment #128793 -
Flags: review?(leaf) → review+
Updated•21 years ago
|
Attachment #128793 -
Flags: superreview?(bryner) → superreview+
Comment 11•21 years ago
|
||
Patch has been checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.5beta
Comment 12•21 years ago
|
||
Works with a 2003-08-04 CVS checkout
Comment 13•21 years ago
|
||
I now get an icon when building on Win XP using gcc. However, I don't get an icon when building Firebird or Thunderbird. Is that the same issue, or should I file a new bug on that?
Comment 14•21 years ago
|
||
Probably the same issue but definitely a different bug. The makefiles for those products were not updated.
Comment 15•21 years ago
|
||
Re my Comment #13. Icons work for WIN32 Gcc builds of Mozilla, Thunderbird and Firebird as of 23/8/03. Verifying...
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•