203540 - RenameField doesn't get NULL/NOT NULL correct

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Bradley Baetz (:bbaetz)]

Not only does it look at the wrong column, it gets the test backwards.

Patch coming. Note that all other users of RenameField call ChangeFieldType on
the field later on (either directly afterwards, or several montsh later for the
bug_activity case), so we don't have to do any fixup for past behaviour.

This does affect the count patch, though

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: fix

The third column is [2], and its NOT NULL, if the 'is null' column is not not
NULL. Make sense? :)

Tested on 4.0.12, and I checked that 3.23 has the same column ordering.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 121839 [details] [diff] [review]
fix

doh.  Wonder if the columns were different in MySQL 3.22 and nobody noticed
when they changed...

Comment 3

[Bradley Baetz (:bbaetz)]

Checked in.