Closed
Bug 203797
Opened 21 years ago
Closed 21 years ago
IDispatch support should allow FUNC_VIRTUAL and FUNC_PUREVIRTUAL
Categories
(Core :: XPConnect, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.5alpha
People
(Reporter: dbradley, Assigned: dbradley)
References
Details
Attachments
(1 file)
784 bytes,
patch
|
adamlock
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
All methods I had encountered thus far, had been of the type FUNC_DISPATCH. We're now encountering some FUNC_PUREVIRTUAL calls. So I'm adding FUNC_PUREVRITUAL and FUNC_VIRTUAL as allowable types.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Comment 2•21 years ago
|
||
-> 1.5a
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.5alpha
Assignee | ||
Comment 3•21 years ago
|
||
Comment on attachment 122015 [details] [diff] [review] Allows FUNC_VIRTUAL and FUNC_PUREVIRTUAL I've not found anything that states I need to do anything different for functions marked with these other types of function. I thought I might have to pass "this" as a parameter or something, but it works fine without that. There's also FUNC_STATIC, but I think its best to ignore those for now. Surely that would be invoked differently.
Attachment #122015 -
Flags: superreview?(alecf)
Attachment #122015 -
Flags: review?(adamlock)
Comment 4•21 years ago
|
||
Comment on attachment 122015 [details] [diff] [review] Allows FUNC_VIRTUAL and FUNC_PUREVIRTUAL sr=alecf
Attachment #122015 -
Flags: superreview?(alecf) → superreview+
Comment on attachment 122015 [details] [diff] [review] Allows FUNC_VIRTUAL and FUNC_PUREVIRTUAL r=adamlock
Attachment #122015 -
Flags: review?(adamlock) → review+
Assignee | ||
Comment 6•21 years ago
|
||
Patch checked in Leaving open for 1.4 branch check in (post Mozilla release)
Assignee | ||
Comment 7•21 years ago
|
||
Closing to get off 1.5a radar, though these should still be checked into 1.4 branch.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•