204135 - List marker glyphs 'disc' and 'circle' are diamond shaped

Status: NEW

(Core :: Layout, defect, P4)

Description

[Mats Palmgren (inactive)]

List marker glyphs 'disc' and 'circle' are diamond shaped when using certain
font sizes. This occurs at 14px and 15px but not with smaller or larger sizes.

Bug occurs with the following in my Preferences:
Proportional: Sans Serif        Size: 14
Sans-serif:   adobe-helvetica-iso8859-1


Bug occurs in 2003-04-30-22 trunk Linux.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase #1

Comment 2

[Mats Palmgren (inactive)]

Attachment: Screenshot of Testcase #1

Comment 3

[Greg K.]

Refer to bug 152588, comment 6.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Roland did some work at some point to make these draw better... so he may know
what's up.

Comment 5

[Jo Hermans]

Dupe of bug 152588 ?

See bug 152588, comment 6, which explains that they're not characters at all,
they're hand-drawn. I think the difference must be caused by the antialiasing of
the real Unicode-codepoints, or maybe one of their Truetype hints, which make
them better circles.

Comment 6

[Roland Mainz]

Can we somehow figure-out whether they are rendered as
a) as glyphs from a specific font
  OR
b) using home-grown code within Mozilla

If we use [b] then the code in
http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsRenderingContextGTK.cpp#1110
should handle the case unless someone messed with the code that we do not use
the nsIRenderingContext::FillEllipse() codepath anymore.

Comment 7

[Boris Zbarsky [:bzbarsky]]

They're done with FillEllipse last I checked.  See nsBulletFrame::Paint() for
details.

Comment 8

[Roland Mainz]

Boris Zbarsky wrote:
> They're done with FillEllipse last I checked.  See nsBulletFrame::Paint() for
> details.

Why does the code from
http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsRenderingContextGTK.cpp#1110
then not kick-in and handle the problem ?!

Comment 9

[Boris Zbarsky [:bzbarsky]]

You tell me.  :)  At most sizes it most certainly does.

Comment 10

[Mats Palmgren (inactive)]

Attachment: Testcase #2

Comment 11

[Mats Palmgren (inactive)]

Attachment: Testcase #3

Comment 12

[Mats Palmgren (inactive)]

Attachment: Patch

Fix nsRenderingContextGTK::FillEllipse/DrawEllipse for certain sizes

Comment 13

[Mats Palmgren (inactive)]

Attachment: Screenshot of Testcase #2, before

Comment 14

[Mats Palmgren (inactive)]

Attachment: Screenshot of Testcase #2, after

Comment 15

[Mats Palmgren (inactive)]

Attachment: Screenshot of Testcase #3, before

Comment 16

[Mats Palmgren (inactive)]

Attachment: Screenshot of Testcase #3, after

Comment 17

[Mats Palmgren (inactive)]

A good way to compare the "before" and "after" screenshots is to load them
in separate tabs and then flip between them.

Comment 18

[Jo Hermans]

*** Bug 293337 has been marked as a duplicate of this bug. ***