204211 - Template builder enhancements

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Jan Varga [:janv]]

1. Template builder should rebuild its data after a batch operation
2. Template builder should notify listeners before and after calling Rebuild()

Comment 1

[Jan Varga [:janv]]

Attachment: patch

Comment 2

[jag (Peter Annema)]

Comment on attachment 122312 [details] [diff] [review]
patch

>Index: content/xul/templates/public/nsIXULTemplateBuilder.idl
>===================================================================

>@@ -42,6 +43,7 @@
> #include "nsISupports.idl"
> #include "nsIRDFCompositeDataSource.idl"
> #include "nsIRDFResource.idl"
>+#include "nsIXULBuilderListener.idl"

interface nsIXULBuilderListener.idl

r=jag

Comment 3

[jag (Peter Annema)]

Without the .idl, of course

Comment 4

[Jan Varga [:janv]]

+    RebuildAll();
...
+    return NS_OK;

should be:

+    nsresult rv = RebuildAll();
...
+    return rv;

Comment 5

[jag (Peter Annema)]

Ah, yeah. r=jag with that change.

Comment 6

[(not reading, please use [e-mail] instead)]

have you smoke tested the other consumers of templates?

(There's a ton of them in mailnews, for example).

mozilla/content/xul...this feels like something for hyatt to review?

if you can't get a review from hyatt, I'll do the sr.

looking at bonsai, jan's the only one to really do any hacking on
mozilla/content/xul in the past year.

Comment 7

[Jan Varga [:janv]]

I found an issue in bookmarks JS code, C++ part of the patch is correct and we
still need it.
I'll try to fix the JS code and get review from Pierre.

Comment 8

[Jan Varga [:janv]]

This becomes too much risky (more changes needed).

Comment 9

[Jan Varga [:janv]]

fixed