Closed
Bug 205213
Opened 21 years ago
Closed 21 years ago
[FIX]Cannot back to non-existant destination anchor after visiting another destination anchor
Categories
(Core :: DOM: Navigation, defect, P1)
Core
DOM: Navigation
Tracking
()
VERIFIED
FIXED
mozilla1.5alpha
People
(Reporter: jason.barnabe, Assigned: bzbarsky)
References
()
Details
(Keywords: testcase)
Attachments
(3 files)
127 bytes,
text/html
|
Details | |
935 bytes,
text/html
|
Details | |
4.01 KB,
patch
|
jag+mozilla
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030510 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030510 Going to an URL with a destination anchor (A HREF="foo.html#Anchor") that is not specified in that document (with A NAME) opens to the top of that page. If you click on a valid destination anchor link, it'll take you to that spot on the page. However, if you then click on the back button, it doesn't return to the top of the page. Subsequent back clicks also do nothing. Reproducible: Always Steps to Reproduce: 1. Go to the link ("SARS" is not a named destination anchor on that page) 2. Click on "HIV". 3. Click back button Actual Results: Nothing Expected Results: Gone back to the top of the page.
Reporter | ||
Comment 1•21 years ago
|
||
Reporter | ||
Comment 2•21 years ago
|
||
Part one and part two must be together in the same folder. I don't think this will work from Bugzilla.
Reporter | ||
Updated•21 years ago
|
Assignee | ||
Comment 3•21 years ago
|
||
Taking.
Assignee: radha → bzbarsky
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.5alpha
Assignee | ||
Updated•21 years ago
|
Summary: Cannot back to non-existant destination anchor after visiting another destination anchor → [FIX]Cannot back to non-existant destination anchor after visiting another destination anchor
Assignee | ||
Comment 4•21 years ago
|
||
Assignee | ||
Comment 5•21 years ago
|
||
Comment on attachment 127217 [details] [diff] [review] Proposed patch The key here is not propagating the return value of GoToAnchor to our caller... The rest is minor cleanup.
Attachment #127217 -
Flags: superreview?(dbaron)
Attachment #127217 -
Flags: review?(jaggernaut)
Comment 6•21 years ago
|
||
Comment on attachment 127217 [details] [diff] [review] Proposed patch r=jag
Attachment #127217 -
Flags: review?(jaggernaut) → review+
Attachment #127217 -
Flags: superreview?(dbaron) → superreview+
Assignee | ||
Comment 7•21 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Component: History: Session → Document Navigation
QA Contact: chrispetersen → docshell
You need to log in
before you can comment on or make changes to this bug.
Description
•