Closed
Bug 206909
Opened 21 years ago
Closed 21 years ago
Make zoomin and zoomout icons work
Categories
(Core Graveyard :: GFX: OS/2, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mkaply, Assigned: mkaply)
Details
(Keywords: fixed1.4)
Attachments
(2 files)
4.88 KB,
patch
|
Details | Diff | Splinter Review | |
4.50 KB,
patch
|
mkaply
:
review+
mkaply
:
superreview+
mkaply
:
approval1.4+
|
Details | Diff | Splinter Review |
The function works, but IS/2 doesn't get the icons.
Assignee | ||
Comment 1•21 years ago
|
||
pointers are already checked in. I've changed the code to be a little more dynamic about loading pointers. I know we have an empty slot at the beginning of the array and it is ugly. Makes the math better
Assignee | ||
Updated•21 years ago
|
Attachment #124077 -
Flags: review?(pedemont)
Comment 2•21 years ago
|
||
How about this? Also, rather than hard coding IDC_COUNT, you could do this "#define IDC_COUNT IDC_HELP - IDC_BASE + 1" at the end of resource.h.
Comment 3•21 years ago
|
||
That second patch also contains a patch to rules.mk. It seems that rc.exe produces *.res files with all upper cases, such that "$(wildcard *.res)" in the GARBAGE statement doesn't catch these files. This means that generated .res files on OS/2 don't get deleted. I had to add an upper case equivalent in there.
Assignee | ||
Updated•21 years ago
|
Attachment #124077 -
Flags: review?(pedemont)
Assignee | ||
Comment 4•21 years ago
|
||
Comment on attachment 124083 [details] [diff] [review] Alternative fix r=mkaply, sr=blizzard (OS/2 specific), a=mkaply
Attachment #124083 -
Flags: superreview+
Attachment #124083 -
Flags: review+
Attachment #124083 -
Flags: approval1.4+
Assignee | ||
Comment 5•21 years ago
|
||
Fixed on trunk and branch
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•