208210 - Unexpected Launch or Opening item by double-clicking scrollbar in download and history sidebar

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[noririty]

When you double click the scrollbar (i.e. to scroll up/down arrow button
quickly), Mozilla Firebird treats as you double-clicked the item.
This might causes security issue when you have downloaded some kind of malware.

Reproducible: Always

Steps to Reproduce:
[[ A. Download sidebar ]] <- Windows only
1. Download many files to show scrollbar in download sidebar.
2. Type [Ctrl]+[E] or Click [View]-[Sidebar]-[Downloads].
3. Select one of the items you downloaded.
4. Double-click scroll up/down arrow button (small triangle) quickly.
Actual Results:  
The item you selected launches unexpectedly without any confirmation.

[[ B. History sidebar ]] <- All
1. Visit and open many pages to show scrollbar in history sidebar.
2. Type [Ctrl]+[H] or Click [View]-[Sidebar]-[History].
3. Click [View]-[By Last Visited].
4. Click to select one page from sidebar.
5. Double-click scroll up/down arrow button (small triangle) quickly.
Actual Results:  
The page you selected opens unexpectedly in current tab.

Expected Results:  
Nothing. Clicking or double-clicking scroll bar should just to scroll.

Comment 1

[Mike Connor [:mconnor]]

Confirmed on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b)
Gecko/20030603 Mozilla Firebird/0.6

Not sure this is part of the Downloading component, the components aren't quite
as clear as in Browser.  As for the security concern, beside that its a bit of
an annoying bug and may indicate a flaw in how the sidebar was implemented in
Firebird.

Comment 2

[Erik]

Confirming using Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.4b)
Gecko/20030603 Mozilla Firebird/0.6

=> changing status to "new" since I didn't find an already filed bug report for
this. Not sure about the component, I'd see this more in "General" since no
component seems to fit 100%

Comment 3

[noririty]

Attachment: proposed patch

Comment 4

[noririty]

Comment on attachment 127355 [details] [diff] [review]
proposed patch

Blake, could you take a look at this?

This patch fixes bustage on double-clicking scrollbar.
I'm sure that this is some sort of security fix.
And very low risk to checking in.

Comment 5

[noririty]

checked in.

Comment 6

[Simon Paquet [:sipaq]]

Verified