Closed Bug 209409 Opened 21 years ago Closed 17 years ago

Thread Pane: column headers for Threads, Read, Junk, Flag/Star have different width

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 383913

People

(Reporter: mbockelkamp, Assigned: henrik)

References

Details

(Keywords: qawanted, Whiteboard: checkin?)

Attachments

(7 files, 4 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030611
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030611

The coulum headers for the "sign columns" (Threads, Read, Junk, Flag) have
different witdth. I think they should have the same because the size of the
images is the same. I'll attach a screenshot.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Attached image Sorted for better view
This is caused by the used gif images, some are 16x16 and one is 18x16. I'll
attach the changed ones. But the junk icon still looks ugly, because the Junk
box isn't centered (it is centered in the used gif).
It seems there is still a problem with the with of the junk colum header.
The ugly Junk box can be fixed by changing threadPane.css:

/* ..... junkStatus column ..... */

treecol.junkStatusHeader {
  list-style-image: url("chrome://messenger/skin/icons/folder-junk.gif");
  padding: 0px 4px 0px 0px;
}

The other column headers don't have the "padding..." line. Removing it solves
the problem. I'll attach screenshots again.
I can't set the Review flag for this bug because there is no attached patch. So
I'm asking for Review this way.
Hi 

Could you please attach the altered version of threadPane.css, and I will be
happy to convert it to a patch and submit it for review.

btw. Have you checked to see if the problem also appears in the modern theme,
and perhaps in thunderbird ?

Assignee: sspitzer → admin
Status: UNCONFIRMED → NEW
Ever confirmed: true
The problem doesn't appear in Modern theme, but it's also present in
Thunderbird. A patch for threadPane.css will follow.
Attached patch patch (obsolete) — Splinter Review
Comment on attachment 128245 [details] [diff] [review]
patch

The images in the zip file is part of the fix.
Attachment #128245 - Flags: superreview?(jaggernaut)
Attachment #128245 - Flags: review?(jaggernaut)
Please note that like the patch for the app suite the images in the zip file is
part of the fix
Hi mscott,

I was told on irc that you are the man for thunderbird fixes, could you please
review the patch.
Comment on attachment 128255 [details] [diff] [review]
Patch for the thunderbird. It has the same problem.

I can check the thread pane change into thunderbird.

Interesting for me, the junk mail icon looks centered in my build.
Attachment #128255 - Flags: superreview+
I'm just going to go ahead and check the thread pane change in for thunderbird.
Hopefully the resized images will soon follow into the trunk. 

Feel free to use me as an r or sr for the trunk threadPane.css change for
classic too.
mailWindow1.css and searchDialog.css need to be patched instead of/along with
threadPane.css for thunderbird.
Updated Patch for Mozilla. Also centers the "readmail.gif" in the colums.
Attachment #128245 - Attachment is obsolete: true
Updated Patch for Thunderbird. Also centers the "readmail.gif" in the colums.
Obsoletes #128255 (I can't set that).
Attachment #128328 - Flags: superreview?(scott)
Attachment #128328 - Flags: review?(scott)
Attachment #128329 - Flags: superreview?(scott)
Attachment #128329 - Flags: review?(scott)
Attachment #128245 - Flags: superreview?(jaggernaut)
Attachment #128245 - Flags: review?(jaggernaut)
Attachment #128329 - Flags: superreview?(scott)
Attachment #128329 - Flags: superreview+
Attachment #128329 - Flags: review?(scott)
Attachment #128329 - Flags: review+
Attachment #128328 - Flags: superreview?(scott)
Attachment #128328 - Flags: superreview+
Attachment #128328 - Flags: review?(scott)
Attachment #128328 - Flags: review+
I just saw in CVS Log (1.16 -> 1.17) of threadPane.css that the now deleted
padding was inserted because of a cropped thread pane Junk icon on Mac (Bug
#194567). So if this is checked in, it should be checked carefully on the three
main platforms.
Attachment #125651 - Attachment is obsolete: true
Attachment #125652 - Attachment is obsolete: true
Attachment #128255 - Attachment is obsolete: true
Attachment #125650 - Flags: superreview?(scott)
Attachment #125650 - Flags: review?(scott)
that bug's currently open (again), could someone test the patch on macosx and
then check this in if nothing interesting is present.
Keywords: qawanted
Whiteboard: checkin?
Comment on attachment 125650 [details]
All images resized to 18x16

trying other reviewer/superreviewer...
Attachment #125650 - Flags: superreview?(mscott)
Attachment #125650 - Flags: superreview?(blizzard)
Attachment #125650 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #125650 - Flags: review?(mscott)
Comment on attachment 125650 [details]
All images resized to 18x16

You can't change the size of folder-junk.gif because the folder pane uses it.
Attachment #125650 - Flags: review?(neil.parkwaycc.co.uk) → review-
Attachment #125650 - Flags: superreview?(blizzard)
Product: Browser → Seamonkey
*** Bug 209414 has been marked as a duplicate of this bug. ***
looks just fine to me in SM 1.5 nightly as shown in attachment 125653 [details]
hasn't been checked in according to Matthias

"see <http://lxr.mozilla.org/seamonkey/source/themes/classic/messenger/threadPane.css#117> and the bug still exists. ...width of the column headers (values are taken from my actual sm 1.5+): threads 25px, read 23px, junk 24px, flag 23px. They should be all equal."
Does the TB patch here still apply to the new theme?
Summary: Thread Pane: column headers for Threads, Read, Junk, Flag have different width → Thread Pane: column headers for Threads, Read, Junk, Flag/Star have different width
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: