209990 - Crash in accessibility when doc is destroyed

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

This is a regresion from bug 202080, where we introduced the new thashtable.

When the doc is destroyed, we end up trying to access a null hash table.

Comment 1

[Aaron Leventhal]

oops should be assigned to me

Comment 2

[Aaron Leventhal]

Attachment: Fixes thashtable destruction, uses comptrs instead of weak refs

I need to test to make sure this still doesn't leak

Comment 3

[Aaron Leventhal]

Attachment: Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

Comment 4

[Kyle Yuan]

Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

r=kyle

Comment 5

[Aaron Leventhal]

Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

I tested, changing mParent to an nsCOMPtr doesn't cause any leaks.

Comment 6

[Alec Flett]

Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

sr=alecf

Comment 7

[Aaron Leventhal]

checked in

Comment 8

[Kyle Yuan]

Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

For making the accessibility feature work better and more stable in 1.4.x, we
need to get this patch in. This fix has been in trunk for a long period. It
won't affect other modules.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 126110 [details] [diff] [review]
Remove unneccessary null setters in InvalidateChildren(), make mParent an nsCOMPtr, fix hash table destruction

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2. 
Kyle, can you all take this into your tree locally until after 1.4.1 ships
(real soon now) and then work with us to get it landed first thing for 1.4.2?