Closed Bug 210069 Opened 21 years ago Closed 21 years ago

Leaks caused by new in process accessibility events

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

Details

(Keywords: access)

Attachments

(1 file)

Use nsCOMptr
837 bytes, patch
yuanyi21
: review+
alecf
: superreview+
asa
: approval1.4.1-
Details | Diff | Splinter Review 
The nsIAccessibleEvent objects created by nsDocAccessible::FireToolkitEvent()
are leaking.

My mistake -- it shouldn't act like a getter, it should release the newly
created object when finished.
Attached patch Use nsCOMptr — — Splinter Review 

    
  

        Attachment #126111 -
        Flags: review?(kyle.yuan)

    
    

    
  
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

r=kyle

        Attachment #126111 -
        Flags: review?(kyle.yuan) → review+

    
    

    
  
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

Short patch.

        Attachment #126111 -
        Flags: superreview?(alecf)

    
    

    
  
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

sr=alecf

        Attachment #126111 -
        Flags: superreview?(alecf) → superreview+

    
    

    
  
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

This patch is very simple and won't affect  any other modules.

        Attachment #126111 -
        Flags: approval1.4.x?

    
    

    
  
Comment on attachment 126111 [details] [diff] [review]
Use nsCOMptr

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2. 
Kyle, can you all take this into your tree locally until after 1.4.1 ships
(real soon now) and then work with us to get it landed first thing for 1.4.2?

        Attachment #126111 -
        Flags: approval1.4.x? → approval1.4.x-

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: