Closed
Bug 210330
Opened 21 years ago
Closed 19 years ago
Underlined links appear as overstrikes
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: doug, Assigned: uriber)
References
()
Details
Attachments
(4 files, 1 obsolete file)
126.17 KB,
image/gif
|
Details | |
737 bytes,
text/html
|
Details | |
65.16 KB,
image/png
|
Details | |
945 bytes,
patch
|
smontagu
:
review+
dbaron
:
approval1.8b2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4) Gecko/20030612 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4) Gecko/20030612 At many sites, including the http://www.mozilla.org/start/ page, hotlinked text with underlines render as overstrikes instead of underlines. Reproducible: Always Steps to Reproduce: 1.Go to the site. That is it. 2. 3. Actual Results: As described above. Expected Results: Displayed the underlined links with underlines rather than overstrikes.
Reporter | ||
Comment 1•21 years ago
|
||
Comment 2•21 years ago
|
||
Over to mac gfx -- sounds like a platform font issue.
Assignee: general → sfraser
Component: Browser-General → GFX: Mac
QA Contact: general → ian
Comment 3•21 years ago
|
||
What font is the page being rendered in? If you change the default font, does the problem go away? What if you change the font size?
Comment 4•20 years ago
|
||
The font used here appears to be "Arial." Using that font, the page (as it now exists) WFM. However, the page is significantly different-looking now than when this bug was originally submitted, due to a site redesign. I always use "Arial" as my sans-serif font, though, and have never experienced this problem on any page. I'm currently using Mozilla 1.8a4 (8/28/04 build) under MacOSX 10.3.5. -- David Lawhon
Assignee | ||
Comment 5•19 years ago
|
||
I'm seeing this issue when the language is set to "he" (Hebrew), and the default font is used (regardless, it appears, of what the default font actually is). This bug is very easy to spot on the Hebrew Wikipedia (http://he.wikipedia.org). Testcase and screenshot coming up. Confirming bug. Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050510 Firefox/1.0+
Assignee: sfraser_bugs → joshmoz
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: ian → mac
Assignee | ||
Comment 6•19 years ago
|
||
Testcase with various combinations of language and font settings.
Assignee | ||
Comment 7•19 years ago
|
||
Screenshot, with default font for Hebrew set to "Lucida Grande".
Assignee | ||
Comment 8•19 years ago
|
||
My first-ever patch. Please be gentle! The issue was that the LangGroup information wasn't passed to GetMetricsFor() - which therefore used the default font associated with the default LangGroup. Since the metrics of this font could be different than those of the default font for the actual language used (Hebrew, in my example) - the underline ended up in the wrong place. I took the method for figuring out the LangGroup from nsFrame::SetFontFromStyle(). I hope this is correct. I guess this means this is not a Mac-specific bug. I sure hope I'm on the right bug at all (it's remotely possible that the original bug was not the same issue).
Assignee | ||
Updated•19 years ago
|
Assignee: joshmoz → nobody
Component: GFX: Mac → Layout: Fonts and Text
QA Contact: mac → layout.fonts-and-text
Assignee | ||
Comment 9•19 years ago
|
||
Comment on attachment 183335 [details] [diff] [review] patch requesting review from bzbarsky. Once again - this is my first patch. Please point out to me whatever I did wrong both in procedure and in code.
Attachment #183335 -
Flags: review?(bzbarsky)
Comment 10•19 years ago
|
||
Comment on attachment 183335 [details] [diff] [review] patch Looks reasonable, though you should be able to just call GetStyleVisibility() (withou the GetStyleContext() part) on a frame. Going to ask Simon for the actual review, though, just in case. We seem to have very few people actually passing the style lang group to GetMetricsFor(); perhaps we need more followup bugs?
Attachment #183335 -
Flags: superreview+
Attachment #183335 -
Flags: review?(smontagu)
Attachment #183335 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 11•19 years ago
|
||
Patch with Boris' comment implemented. Carrying over flags (hope this is OK).
Assignee | ||
Updated•19 years ago
|
Attachment #183335 -
Attachment is obsolete: true
Attachment #183372 -
Flags: superreview+
Attachment #183372 -
Flags: review?(smontagu)
Assignee | ||
Updated•19 years ago
|
Attachment #183372 -
Flags: superreview+
Assignee | ||
Updated•19 years ago
|
Attachment #183293 -
Attachment description: screenshot of perv. testcase → screenshot of testcase
Assignee | ||
Updated•19 years ago
|
Attachment #183335 -
Flags: review?(smontagu)
Comment 12•19 years ago
|
||
(In reply to comment #10) > We seem to > have very few people actually passing the style lang group to GetMetricsFor(); > perhaps we need more followup bugs? Yes, I think we do. I said something similar in bug 100762.
Comment 13•19 years ago
|
||
Comment on attachment 183372 [details] [diff] [review] patch v. 2 r=smontagu.
Attachment #183372 -
Flags: review?(smontagu) → review+
Comment 14•19 years ago
|
||
Comment on attachment 183372 [details] [diff] [review] patch v. 2 requesting 1.8b2 approval. This is a very safe patch that should make us paint text decorations better.
Attachment #183372 -
Flags: approval1.8b2?
Comment on attachment 183372 [details] [diff] [review] patch v. 2 a=dbaron, although you really don't need the |visibility| variable at all...
Attachment #183372 -
Flags: approval1.8b2? → approval1.8b2+
Updated•19 years ago
|
Assignee: nobody → uriber
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•