Closed
Bug 210556
Opened 21 years ago
Closed 21 years ago
Should be able to serialize <li> in plaintext without the bullet characters added in.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: caillon, Assigned: caillon)
Details
Attachments
(1 file, 1 obsolete file)
1.82 KB,
patch
|
harishd
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
<ul><li> will always hit this bit of code in plaintext serialization: 768 static char bulletCharArray[] = "*o+#"; 769 NS_ASSERTION(mULCount > 0, "mULCount should be greater than 0 here"); 770 char bulletChar = bulletCharArray[(mULCount - 1) % 4]; 771 mInIndentString.Append(PRUnichar(bulletChar)); This should not happen unless the caller cares about formatted output. I noticed this when implementing Node.textContent (see the DOM 3 core WD). After I do some testing to make sure this doesn't break things like plaintext editing, I'll put out a patch.
Assignee | ||
Comment 1•21 years ago
|
||
Make OutputRaw do the right thing.
Assignee | ||
Comment 2•21 years ago
|
||
Comment on attachment 126661 [details] [diff] [review] The smack down Wrong patch. Sigh.
Attachment #126661 -
Attachment is obsolete: true
Assignee | ||
Comment 3•21 years ago
|
||
Assignee | ||
Comment 4•21 years ago
|
||
Comment on attachment 126662 [details] [diff] [review] The real patch Okay, so this makes raw mean raw. This does not cause any regressions since nobody is relying on raw output in the plaintext serializer (except Node.textContent, which is the reason for this bug being filed). I ran tests against editor source view, dnd, copy, and mail plaintext view just to be sure though, and everything seemed happy.
Attachment #126662 -
Flags: superreview?(jst)
Attachment #126662 -
Flags: review?(harishd)
Comment on attachment 126662 [details] [diff] [review] The real patch Make sure that this patch does not break mail and news in the plain text mode. r=harishd
Attachment #126662 -
Flags: review?(harishd) → review+
Comment 6•21 years ago
|
||
Comment on attachment 126662 [details] [diff] [review] The real patch sr=jst
Attachment #126662 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Comment 7•21 years ago
|
||
Fix checked in 07/02/2003 17:34.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•