211195 - [FIX]GetFocusControllerForDocument should not return raw addrefed ptr

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

It should return already_AddRefed<nsIFocusController>.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed change

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 126803 [details] [diff] [review]
Proposed change

r/sr=me

Comment 3

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

For this kind of thing, why not just return a raw pointer and let the caller
addref if they want? Like we're doing with nsIFrame::GetContent() etc?

Comment 5

[Boris Zbarsky [:bzbarsky]]

In this case, that would involve calling an XPCOM getter and then releasing the
pointer it gave you before returning it, unless I also changed the nsPIDOMWindow
interface...  I could do that, I suppose, but I wasn't sure that was desired in
the first place -- jst does not seem to like things returning weak pointers much....

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I see, thanks.