211272 - Double-quote munger breaks word wrapping

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

When someone says a line with a large number of ` or ' characters, they are
mungered into the Unicode open and close double-quotes, but it then prevents any
word wrapping from occuring in the quotes.

Reproducible: Always

Steps to Reproduce:
1. Open ChatZilla.
2. Type "/echo " and a large number of '-characters. Increase as needed until
width of window is reached.

Actual Results:  
Client are gets a horizontal scroll bar.

Expected Results:  
Quotes should wrap just like any other 'long word'.

This problem does not occur when the 'Double quotes' munger is turned off.

The only real problem here is the horizontal scroll bar, which makes reading the
contents of a channel quite hard. :)

Comment 1

[[e-mail]]

Control characters also seem to confuse the wrapper, e.g.
~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~0x1b[6~/who
(the ~0x1b displays inside its own set of []s which don't copy & paste)

Comment 2

[:Gijs (he/him)]

Attachment: Patch

I expect this doesn't fix the case Neil describes, but it should fix the quote case (does in my testing). And it saves us a bunch of lines by using the const we define in static.js for the munger cruft. Ugh. :-(

Comment 3

[:Gijs (he/him)]

Attachment: Patch v2 [checked in]

Better fixing of the namespace cruft.

Comment 4

[James Ross]

Comment on attachment 341690 [details] [diff] [review]
Patch v2 [checked in]

Can you do a follow for showCtrlChar() then?

Comment 5

[:Gijs (he/him)]

Comment on attachment 341690 [details] [diff] [review]
Patch v2 [checked in]

Checking in mozilla/extensions/irc/js/lib/utils.js;
/cvsroot/mozilla/extensions/irc/js/lib/utils.js,v  <--  utils.js
new revision: 1.73; previous revision: 1.72
done
Checking in mozilla/extensions/irc/xul/content/mungers.js;
/cvsroot/mozilla/extensions/irc/xul/content/mungers.js,v  <--  mungers.js
new revision: 1.17; previous revision: 1.16
done
Checking in mozilla/extensions/irc/xul/content/static.js;
/cvsroot/mozilla/extensions/irc/xul/content/static.js,v  <--  static.js
new revision: 1.287; previous revision: 1.286
done
Checking in mozilla/extensions/irc/xul/lib/munger.js;
/cvsroot/mozilla/extensions/irc/xul/lib/munger.js,v  <--  munger.js
new revision: 1.28; previous revision: 1.27
done

Comment 6

[:Gijs (he/him)]

Attachment: [checked in] Same patch for ctrl chars

I haven't tested this yet, but it should pretty much work the same way...

Comment 7

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/mungers.js;
/cvsroot/mozilla/extensions/irc/xul/content/mungers.js,v  <--  mungers.js
new revision: 1.18; previous revision: 1.17
done