Closed
Bug 212767
Opened 21 years ago
Closed 21 years ago
Crash when initializing Midas (setting designMode and others)
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: emaijala+moz, Assigned: emaijala+moz)
Details
(Keywords: crash)
Attachments
(6 files)
14.14 KB,
application/x-zip-compressed
|
Details | |
6.15 KB,
text/plain
|
Details | |
5.27 KB,
text/plain
|
Details | |
10.03 KB,
text/plain
|
Details | |
1.32 KB,
patch
|
Brade
:
review+
dbaron
:
superreview+
asa
:
approval1.7a+
|
Details | Diff | Splinter Review |
3.38 KB,
patch
|
Details | Diff | Splinter Review |
I've experienced a crash with Midas in an intranet application. It works usually fine, but there is one specific page which causes it to crash. I took the contents of that page and minimized it to a crashing test case, which I will attach to this bug. Running trunk build 2003070107 on WinXP, also happens with 20030714.
Assignee | ||
Comment 1•21 years ago
|
||
A test case simplified from a real life crash case.
Comment 2•21 years ago
|
||
Comment 3•21 years ago
|
||
*** This bug has been marked as a duplicate of 171949 ***
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 4•21 years ago
|
||
My stack is completely different.
Assignee | ||
Comment 5•21 years ago
|
||
Reopening. There was yet another place it crashed in talkback 21908653q.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 6•21 years ago
|
||
I'm attaching the purify data, it shows where the object was created and destroyed that the QI is failing on. From what I can tell is that an event is fired, and the command controller still has a reference to the editor which was destroyed when leaving nsEditingSession::TearDownEditorOnWindow. I suspect maybe there's some kind of contract between the nsEditingSession and the command controller built, that it keeps things alive as long as needed. I think the nsEditingSession::TearDownEditorOnWindow needs to clean up the command controller before it exits, since I think all references to the object in question will be gone.
Comment 8•21 years ago
|
||
Duplicate of bug 211348?
Assignee | ||
Comment 9•21 years ago
|
||
Need to null out the weak refs to the editor on the controllers before it's destroyed (nulled out on the docshell). Otherwise there is a small timeframe when someone can try to use the destroyed editor. This fixes the crash my stack and the Purify stack show.
Assignee | ||
Updated•21 years ago
|
Assignee: brade → ere
Status: NEW → ASSIGNED
Assignee | ||
Updated•21 years ago
|
Attachment #140075 -
Flags: review?(mozeditor)
Assignee | ||
Updated•21 years ago
|
Attachment #140075 -
Flags: superreview?(bz-vacation)
Comment 10•21 years ago
|
||
It'll take me some time (two weeks or more, possibly) to get to this review -- I'm somewhat behind on reviews at the moment. For future reference, using the -p flag to diff makes patches like this far more readable...
Assignee | ||
Comment 11•21 years ago
|
||
Oops, I did it again. This is the same with some more context.
Comment 12•21 years ago
|
||
Comment on attachment 140088 [details] [diff] [review] Patch v1 with some more context Are there any leaks? Is "PreDestroy" being called? Maybe the ordering thing I was worried about is the selection and doc state listener; I'm not sure (sorry).
Assignee | ||
Comment 13•21 years ago
|
||
No problem, I'll test it.
Assignee | ||
Comment 14•21 years ago
|
||
PreDestroy is being called just fine. As far as I can see the patch causes no problems or changes in behavior.
Assignee | ||
Comment 15•21 years ago
|
||
Comment on attachment 140075 [details] [diff] [review] Patch v1 Seeking r from Brade who seems to know this stuff well :)
Attachment #140075 -
Flags: superreview?(bz-vacation)
Attachment #140075 -
Flags: review?(mozeditor)
Attachment #140075 -
Flags: review?(brade)
Comment 16•21 years ago
|
||
looks ok to me.
Assignee | ||
Comment 17•21 years ago
|
||
Comment on attachment 140075 [details] [diff] [review] Patch v1 That would be an r+?
Attachment #140075 -
Flags: superreview?(dbaron)
Attachment #140075 -
Flags: superreview?(dbaron) → superreview+
Comment 18•21 years ago
|
||
Comment on attachment 140075 [details] [diff] [review] Patch v1 r=brade (assuming mail compose and composer have both been tested and no regressions found)
Attachment #140075 -
Flags: review?(brade) → review+
Assignee | ||
Comment 19•21 years ago
|
||
Comment on attachment 140075 [details] [diff] [review] Patch v1 Yes, I wasn't able to find any problems in mail compose or composer. Requesting approval for 1.7a.
Attachment #140075 -
Flags: approval1.7a?
Comment 20•21 years ago
|
||
Comment on attachment 140075 [details] [diff] [review] Patch v1 a=chofmann for 1.7a
Assignee | ||
Comment 21•21 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
Updated•21 years ago
|
Attachment #140075 -
Flags: approval1.7a? → approval1.7a+
Comment 22•20 years ago
|
||
i still see this problem in 1.7.3 on win2k.
Comment 23•20 years ago
|
||
so file a new bug with a stack trace.
You need to log in
before you can comment on or make changes to this bug.
Description
•