Closed Bug 21331 Opened 25 years ago Closed 25 years ago

[dogfood] find dialog replaces content window

Categories

(SeaMonkey :: General, defect, P2)

x86
Other

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: buster, Assigned: travis)

References

()

Details

(Whiteboard: [PDT+] needs estimated fix date.... How about today? It's fixed. :))

1. open the browser to the default page
2. File > Open Web Location
3. enter a url (I used www.vanguard.com fwiw)
4. click the "open in new window" box
5. the new window opens, the url loads properly
6. Search > Find On This Page
7. The find dialog replaces the newly-opened window, rather than popping up in a
dialog!
Summary: find dialog replaces content window → [dogfood] find dialog replaces content window
I use multiple browser windows all the time, and this looks aweful.  Proposing
for dogfood.
Whiteboard: [PDT+]
Regression==PDT+
Assignee: leger → hyatt
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
*** This bug has been marked as a duplicate of 20493 ***
Status: RESOLVED → REOPENED
QA Contact: leger → paulmac
20493 has been marked fixed, but this still happens with 121411 build on Windows
and Linux, so re-opening. Note, this only happens with File Open Web Location,
not File New Navigator Window.

Is this really dogfood? Workaround is to use New Navigator Window then enter the
URL you want.
Resolution: DUPLICATE → ---
Priority: P3 → P2
Whiteboard: [PDT+] → [PDT+] needs estimated fix date
Target Milestone: M13
targetting p2 for m13, needs estimated fix date.
Assignee: hyatt → travis
Status: REOPENED → NEW
This is not my bug.  Reassigning to travis.
Status: NEW → ASSIGNED
I have a fix in hand....  The patch is:

===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/find/src/nsFindComponent.cpp,v
retrieving revision 1.38
diff -u -r1.38 nsFindComponent.cpp
--- nsFindComponent.cpp 1999/11/16 20:05:19     1.38
+++ nsFindComponent.cpp 1999/12/15 00:15:37
@@ -795,9 +795,9 @@
                     void *stackPtr;
                     jsval *argv = JS_PushArguments( jsContext,
                                                     &stackPtr,
-                                                    "svs%ip",
+                                                    "sss%ip",
                                                     url,
-                                                    JSVAL_NULL,
+                                                    "_blank",
                                                     "chrome,resizable=no,depend
ent=yes",
                                                     (const nsIID*)(&nsISearchCo
ntext::GetIID()),
                                                     (nsISupports*)arg );

===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/openLocation.js,v
retrieving revision 1.6
diff -u -r1.6 openLocation.js
--- openLocation.js     1999/11/06 03:39:29     1.6
+++ openLocation.js     1999/12/15 00:16:32
@@ -77,7 +77,7 @@
                browser.loadUrl( url );
        } else {
                /* User wants new window. */
-        window.opener.openDialog( "chrome://navigator/content/navigator.xul", n
ull, "all,dialog=no", url );
+        window.opener.openDialog( "chrome://navigator/content/navigator.xul", "
_blank", "all,dialog=no", url );
        }

        return true;
BTW, this also fixes a bug where if you did Open Location with "open in new
window" clicked it would open into the same new window each time.  Not sure if
there is a bug number for that....
The fix is correct.  I missed these two "open" calls when I changed lots of
others a while back.  Thanks, Travis.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
Whiteboard: [PDT+] needs estimated fix date → [PDT+] needs estimated fix date.... How about today? It's fixed. :)
Status: RESOLVED → VERIFIED
verified fixed with 12/15 builds
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.