213768 - reverse sorting by thread broken

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[David :Bienvenu]

clicking on the thread column when already threaded isn't reversing the thread
sort. Patch upcoming.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

this has r/sr=mscott - if user clicks on thread column and we're already
threaded, just reverse sort threads by id

Comment 2

[David :Bienvenu]

fix checked in.

Comment 3

[[e-mail]]

This is confusing me. I thought that the point of the thread icon was to turn
threading on/off without changing any other sort setting...

Comment 4

[David :Bienvenu]

No, it's always had three states:

0. Not threaded
1. If you're not threaded, clicking it will sort by thread in id order.
2. Clicking again will reverse the sort.

Comment 5

[[e-mail]]

Ah, I thought that sorting had been changed recently to allow sorting by
arbitrary column while threading, thus the thread column header would just turn
threading on/off without changing the underlying sort order. At least, that's
how I thought 4.x did it, but when did I last use 4.x :-)

Comment 6

[David :Bienvenu]

4.x behaved exactly like Moz 1.2,1.3,1.4, etc. I did add a currently hidden pref
to make clicking on a column other than the thread column not do a flat sort.
So, if "mailnews.thread_pane_column_unthreads" is set to false, and you're
currently threaded, clicking on the subject column will sort the threads by
subject. And even if you don't have that pref set to false, using the view |
sort  menu items will sort threads, if you're currently threaded. None of this
is ideal, but I'm trying to find a way to keep two sets of people somewhat happy.