215121 - About box text is invisible when OS system colors set to white text

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alexander O'Neill]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030804 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030804 Mozilla Firebird/0.6.1

The background color of the Firebird About box is hardcoded to white.  When
windows system colors specify white text, the text in the about box is invisible.

Specifying text colors in teh Firebird options does not affect text in the About
box.

Reproducible: Always

Steps to Reproduce:
1. Use the Windows display properties, go to 'Appearance' and choose the
'High-Contrast Black' theme.  Windows recommends restarting to fully switch
color schemes, but this usually isn't necessary in practice.
2. Start Firebird
3. Go to Help | About Mozilla Firebird

Actual Results:  
About box text shows up as white text on a white background, making it
impossible to read.

Expected Results:  
The About box should not hardcode a background color.  Either completely obey
the Windows system colors, the configured Firebird colors.  Alternatively,
hard-code text color as well, though this is not as good a solution.

Comment 1

[David P James]

Attachment: About popup with dark OS theme in Linux

Seems to be Windows-only; FB is obeying OS colours with GTK2 build in Linux.

Comment 2

[David P James]

Attachment: Default Qute theme this time - shows bug.

Silly me - I took that shot using the Pinball theme (which I maintain) which
does obey System Colours (sorry). The default theme does not, as this
screenshot shows.

Comment 3

[David P James]

Confirming, assigning to Arvid, taking QA, sorry for the bugspam :)

Comment 4

[James Ross]

Attachment: Adds CSS color attribute where background-color is set.

Comment 5

[David P James]

noririty - can you take a look at this? It's simple enough - we just force the
text colour to always be black and the background always be white on the about:
dialog. That's probably preferable to the other option, which is to have system
field colours for the background (as in my first screenshot above). Pinball will
now be using the scheme in the patch for that reason.

Comment 6

[noririty]

Comment on attachment 129527 [details] [diff] [review]
Adds CSS color attribute where background-color is set.

r=me

Comment 7

[Michael Newton]

There really shouldn't be any hard coded colour values in the browser at all,
they should all be system colours.  Maybe the scope of this bug should be
changed, or a new one filed?

Comment 8

[James Ross]

Michael, did you have a look at the dialog? The reason for the fixed background
colours is so that it matches an image. The inner box (the UA string box) could
in theory be done using system colours (for background and forground) but would
look completely out of place in most colours schemes because it would still be
atop the fixed background colour.

Just my thoughts on it (and wasn't this checked in at 08/25/2003 09:41?).

Comment 9

[David P James]

Yes, this was checked in

-->Fixed