216257 - Add "Events this month" to dropdown selection list in events pane.

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, enhancement, P4)

Description

[k b]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030812
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030812;   cal 20030811

wish:
adding selection for "Events this month" to dropdown selection list in events pane.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Matthew (lilmatt) Willis]

Reasonable enhancement request. 
status -> NEW
hardware/OS -> ALL
component -> Front End
priority -> P4

Taking

Comment 2

[Mostafa Hosseini]

Please cc me on bugs you reassign.

Comment 3

[Matthew (lilmatt) Willis]

Reporter:
"Events in the Next Month" brings up events for the next 31 days, irrespective
of the calendar month.

Does this do what you want, albeit with a possible poor choice of label, or do
you want a selection where where today is October 22, you can see all of
October's events?

Comment 4

[k b]

the current month, not the next 31 days.

Comment 5

[Matthew (lilmatt) Willis]

Attachment: rev0 - trunk - patch adds "Events in this calendar month" option, and clarifies language of other options

This patch adds "Events in this calendar month" as an option.
It also clarifies the other options, "next 7 days", "next 14 days", "next 31
days"

Comment 6

[Matthew (lilmatt) Willis]

Attachment: rev1 - trunk - diff run with -u8pN (sorry)

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 163047 [details] [diff] [review]
rev1 - trunk - diff run with -u8pN (sorry)

minusing review from me... (no review originally requested) [I am not
officially a peer, though this I can save mostafah time on]

>RCS file: /cvsroot/mozilla/calendar/resources/locale/cs-CZ/calendar.dtd,v
>-<!ENTITY calendar.events.filter.week.label "Události tohoto týdne">
>-<!ENTITY calendar.events.filter.2weeks.label "Události příštích dvou týdnů">
>-<!ENTITY calendar.events.filter.month.label "Události následujícího měsíce">
>+<!ENTITY calendar.events.filter.next7Days.label "Události tohoto týdne">
>+<!ENTITY calendar.events.filter.next14Days.label "Události příštích dvou týdnů">
>+<!ENTITY calendar.events.filter.thisCalendarMonth.label "Events in this Calendar Month">
>+<!ENTITY calendar.events.filter.next31Days.label "Události následujícího měsíce">

Nit: Try to keep consistent Ordering (See Next), the following section would be
easiest to fix

>RCS file: /cvsroot/mozilla/calendar/resources/locale/en-US/calendar.dtd,v
>-<!ENTITY calendar.events.filter.week.label "Events This Week">
>-<!ENTITY calendar.events.filter.2weeks.label "Events Next 2 Weeks">
>-<!ENTITY calendar.events.filter.month.label "Events In The Next Month">
>+<!ENTITY calendar.events.filter.next7Days.label "Events in the Next 7 Days">
>+<!ENTITY calendar.events.filter.next14Days.label "Events in the Next 14 Days">
>+<!ENTITY calendar.events.filter.next31Days.label "Events in the Next 31 Days">
>+<!ENTITY calendar.events.filter.thisCalendarMonth.label "Events in this Calendar Month">


>RCS file: /cvsroot/mozilla/calendar/sunbird/base/content/calendar.xul,v
>                 <menuitem id="event-filter-today"
>                           label="&calendar.events.filter.today.label;"
>                           value="today"/>
>-                <menuitem id="event-filter-week"
>+                <menuitem id="event-filter-next7Days"
>                           label="&calendar.events.filter.week.label;"
>-                          value="week"/>
>+                          value="next7Days"/>
>                 <menuitem id="event-filter-2weeks"
>                           label="&calendar.events.filter.2weeks.label;"
>                           value="2weeks"/>
>-                <menuitem id="event-filter-month"
>-                          label="&calendar.events.filter.month.label;"
>-                          value="month"/>
>+                <menuitem id="event-filter-next31Days"
>+                          label="&calendar.events.filter.next31Days.label;"
>+                          value="next31Days"/>
>+                <menuitem id="event-filter-thisCalendarMonth"
>+                          label="&calendar.events.filter.thisCalendarMonth.label;"
>+                          value="thisCalendarMonth"/>

You missed [all] the label and value changes in here, please correct.

Thanks for your effort on this, personally the rest looks good. (though r?
mostafah and not me for revised patch)

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

If you add 'events this calendar month', you should also add 'events this
calendar week' etc. This makes the list real long. Is this a good idea?

Comment 9

[Matthew (lilmatt) Willis]

(In reply to comment #8)
> If you add 'events this calendar month', you should also add 'events this
> calendar week' etc. This makes the list real long. Is this a good idea?

I guess that's up to Mostafa. I'll add it if he wants it.

Comment 10

[Matthew (lilmatt) Willis]

Attachment: rev2 - trunk - fixes Justin's comments, and removes DOS lines breaks from 3 .dtd files

Comment 11

[Michiel van Leeuwen (email: mvl+moz@)]

The question is _why_ you want to add events this calendar month.
comment 0 doesn't give any reason.

Comment 12

[gekacheka]

See Bug 262729, reporter's previous request.

Comment 13

[Mostafa Hosseini]

Comment on attachment 163130 [details] [diff] [review]
rev2 - trunk - fixes Justin's comments, and removes DOS lines breaks from 3 .dtd files

However I will keep the current entities in the dtd files as they are and just
add the new ones. There is a strong chance of us needing them later.

Comment 14

[Mostafa Hosseini]

Checked in. Thanks

Comment 15

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!