Closed
Bug 216523
Opened 21 years ago
Closed 21 years ago
t/Support/Files.pm fails to include Bugzilla/Template/Plugin/Bugzilla.pm in the file list
Categories
(Bugzilla :: Testing Suite, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: justdave, Assigned: zach)
Details
Attachments
(1 file, 1 obsolete file)
646 bytes,
patch
|
jouni
:
review+
|
Details | Diff | Splinter Review |
t/Support/Files.pm fails to include Bugzilla/Template/Plugin/Bugzilla.pm in the file list. The code which looks for files to test only recurses two levels deep under the Bugzilla directory.
Assignee | ||
Comment 1•21 years ago
|
||
Let's put the right patch on the right bug this time ;) It would be good to use File::Find and do this the "right" way, but I think this will do the job for now.
Assignee | ||
Updated•21 years ago
|
Attachment #130007 -
Flags: review?
Comment 2•21 years ago
|
||
Comment on attachment 130007 [details] [diff] [review] Patch v1 >-@files = (glob($file), glob('Bugzilla/*.pm'), glob('Bugzilla/*/*.pm')); >+@files = (glob($file), glob('Bugzilla/*.pm'), glob('Bugzilla/*/*.pm'), glob('Bugzilla/*/*/*.pm')); Wrap the line so that it doesn't exceed 80 chars, and r=jouni.
Attachment #130007 -
Flags: review? → review+
Comment 3•21 years ago
|
||
Attachment #130007 -
Attachment is obsolete: true
Comment 4•21 years ago
|
||
Comment on attachment 135840 [details] [diff] [review] Zach's patch with jouni's comments Sure...
Attachment #135840 -
Flags: review+
Updated•21 years ago
|
Flags: approval?
Reporter | ||
Comment 5•21 years ago
|
||
wish it used File::Find, but oh well :)
Flags: approval? → approval+
Reporter | ||
Updated•21 years ago
|
Target Milestone: --- → Bugzilla 2.18
Reporter | ||
Comment 6•21 years ago
|
||
zach: ping
Comment 7•21 years ago
|
||
Zach, how about a CVS commit on this? :) If you want me to do it or somebody else with CVS commit privs for webtools, I'm sure they'll be happy to help. :)
Comment 8•21 years ago
|
||
If nobody checks this in by the end of this week, then I'll take the liberty to checkin it myself, unless someone strongly objects.
Comment 9•21 years ago
|
||
Check it in :-) Gerv
Comment 10•21 years ago
|
||
Checking in t/Support/Files.pm; /cvsroot/mozilla/webtools/bugzilla/t/Support/Files.pm,v <-- Files.pm new revision: 1.15; previous revision: 1.14 done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•