2178 - bugs count charts are not displayed for products with spaces in the name

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, defect, P1)

Description

[Jay Ball]

bugzilla will not display a bug chart for any products with spaces in the name.
this is because of: <img src="data/mining/name with spaces.gif"> in the
report.cgi generated html.

a simple fix is to insert this after line 468 in report.cgi:

        $image =~ s/ /%20/g;

Comment 1

[Terry Weissman]

Reassigning to [e-mail], who now has front-line responsibility for
all Bonsai and Bugzilla bugs.

Comment 2

[Terry Weissman]

Reassigning back to me.  That stuff about me no longer being the front-line
person responsible for Bugzilla and Bonsai turned out to be short-lived.
Please pardon our confusion, and I'm very sorry about the spam.

Comment 3

[randall.whitman]

Another way to patch it would be to use url_quote; this may handle additional
characters other than space that need to be escaped (though the only issue at
our site, as with the reporter, is spaces in the name).  Here is the patch I
made at our site (diff -u):

        $img->gif (*IMAGE, \@data);
        close IMAGE;

+        ### randall 2000-01-04  n.b. url-quote affects slash as well as space.
+        $imageUrl = $dir . "/" . url_quote($file) . ".gif";
        print <<FIN;
-<img src="$image">
+<img src="$imageUrl">
 <br clear=left>
 <br>
 FIN

Comment 4

[randall.whitman]

Error in previous addition to comments; the second added line should be:
+        my $imageUrl = $dir . "/" . url_quote($prodname) . ".gif";

Apologies for the double comment (diff'ed the wrong revision first time).

Comment 5

[aclark]

Attachment: patch to fix this bug, very similar to ideas mentioned in comments previously

Comment 6

[Dave Miller [:justdave]]

I just ran into this on my site, too.  I just cvs updated again this morning. :)  
This looks pretty obvious, any reason it hasn't been checked in yet?

Comment 7

[Terry Weissman]

Because I'm a loser?

Upping priority to P1, which is where I will hopefully first look for things to
do when I actually have a few cycles to spend on Bugzilla stuff.

Comment 8

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 9

[Tara Hernandez]

Don--looks like this is already has a patch.  Be the patch, Luke.

Comment 10

[Dave Miller [:justdave]]

*** Bug 36678 has been marked as a duplicate of this bug. ***

Comment 11

[Don McCasland]

I'm reviewing the patch now.

Comment 12

[Don McCasland]

ok, checked in.  closing bug.

Comment 13

[leger]

Looks good!  Marking Verified.

Comment 14

[Dave Miller [:justdave]]

*** Bug 36678 has been marked as a duplicate of this bug. ***

Comment 15

[Dave Miller [:justdave]]

Moving to Bugzilla product