Closed Bug 218967 Opened 21 years ago Closed 21 years ago

warning: initializer does not fit or is out of range: -128

Categories

(NSPR :: NSPR, defect)

Product:
NSPR
Component:
NSPR
Platform:
x86
Solaris
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: timeless, Assigned: wtc)

Details

(Whiteboard: [4.5])

Attachments

(1 file, 1 obsolete file)

Use regular octal constants rather than character constants as initializers
2.64 KB, patch
Details | Diff | Splinter Review 
Solaris 9 Sparc (deathstarii) Forte6
"/export/home/timeless/mozilla/nsprpub/lib/libc/src/strccmp.c", line 55:
warning: initializer does not fit or is out of range: -128

warning repeats for values -128..-1.
Attached patch don't mark uc array as unsigned (obsolete) — — Splinter Review 

    
  

        Attachment #131267 -
        Flags: review?(wchang0222)

    
    

    
  


  
This patch avoids the type casts.

    
    

    
  
I checked in my patch on the NSPR trunk (NSPR 4.5) and
NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.6 alpha).

timeless, thank you for tracking this down and suggesting
a fix.  Your fix also works, but I prefer a solution that
doesn't use any type cast.  (This is a matter of taste.)
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: [4.5]

    
    

    
  
vrfy fixed
Status: RESOLVED → VERIFIED

    
  

        Attachment #131267 -
        Attachment is obsolete: true

        Attachment #131267 -
        Flags: review?(wtchang)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: