219151 - nsMsgProtocol::GetFileFromURL could be improved

Status: NEW

(MailNews Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

208   nsCAutoString urlSpec;
209   aURL->GetPath(urlSpec);
210   urlSpec.Insert(NS_LITERAL_CSTRING("file://"), 0);
211   nsresult rv;
212 
213 // dougt - there should be an easier way!
214   nsCOMPtr<nsIURI> uri;
215   if (NS_FAILED(rv = NS_NewURI(getter_AddRefs(uri), urlSpec.get())))
216       return rv;
217 
218   nsCOMPtr<nsIFileURL>    fileURL = do_QueryInterface(uri);
219   if (!fileURL)   return NS_ERROR_FAILURE;
220 
221   return fileURL->GetFile(aResult);
222   // dougt

this looks like it could use NS_NewLocalFile insted of creating a file url, see
http://lxr.mozilla.org/seamonkey/source/xpcom/build/nsXPCOM.h#188

Comment 1

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 2

[buovjaga]

Still seems to be valid: https://hg.mozilla.org/comm-central/file/tip/mailnews/base/util/nsMsgProtocol.cpp#l172