Closed Bug 219167 Opened 21 years ago Closed 18 years ago

http://www.mozilla.org/foundation/donate.html doesn't validate

Categories

(www.mozilla.org :: General, defect)

Product:
www.mozilla.org
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: aguertin+bugzilla, Assigned: cameron)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

encode ampersands correctly
1.56 KB, patch
reed
: review+
Details | Diff | Splinter Review 
http://www.mozilla.org/foundation/donate.html is missing several </a> tags and
also has several "document type does not allow element ... here" errors. 

Never done anything with dependencies, but this blocks bug 151557, right?
Attached file Quick fix to make it 4.01 transitional (obsolete) — 
This fixes it... I added </a>'s on lines 120, 186, 210, and 240, changed <div>
and </div> to <span> and </span> on lines 186, 210, and 240, and removed
border="0" on lines 205 and 230 (don't know if that last bit will cause any
problems with borders showing up on older browsers...). 

It should probably be noted that the page uses a meta tag for character set,
and I remember reading just a minute ago (somewhere on *.mozilla.org) about
that being bad.
fixed
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Summary: http://www.mozilla.org/foundation/donate.html doesn't validate → http://www.mozilla.org/foundation/donate.html doesn't validate
No, it's not fixed. The w3c validator still complains about border="0" in two
places, line 189 and 230. 

(and I messed up in my comments last time, 205 should have been 189)
validator.w3.org says:
Line 189, column 57:  there is no attribute "BORDER"  (explain...).
...mage" src="x-click-but21.gif" border="0" name="submit" alt="Make a Donation"

-> reopening.

It's also rendered in quirks mode. The DTD should look like
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
According to http://mozilla.org/docs/web-developer/quirks/doctypes.html
"the public identifier "-//W3C//DTD HTML 4.01 Transitional//EN", without a
system identifier" triggers quirks mode.

"The public identifier "-//W3C//DTD HTML 4.01 Transitional//EN", with a system
identifier" triggers almost standards mode. So please switch to the doctype I
mentioned in comment 4.
David, you only fixed the error at line 189, but there's another border="0" at
line 211! Please also use a valid doctype, see comment 6.
should work now
and I'm daniel, not david
It's now valid HTML 4.01 transitional.
Thanks Daniel! Sorry 'bout the name confusion.
->fixed.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
After redesign, no longer validates. Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://validator.w3.org/check?uri=http%3A%2F%2Fwww.mozilla.org%2Ffoundation%2Fdonate.html

re-fixed
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
This one still (or again) has an error.
URL: http://www.mozilla.org/foundation/don... → http://validator.w3.org/check?uri=htt...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch patch #1 (obsolete) — — Splinter Review 
This one fixes some of the indenting as well and removes the table. However,
the table should probably be replaced with a DIV which get the double border
effect, no?
Nicolas, for some reason I can't request a review on the patch. Could you take a
look at it? (I'm asking you since you offered helping out, if you don't have
that many time, just leave it.)
Checking in mozilla-org/html/foundation/donate.html;
/cvsroot/mozilla-org/html/foundation/donate.html,v  <--  donate.html
new revision: 1.25; previous revision: 1.24
done
Status: REOPENED → RESOLVED
Closed: 21 years ago → 20 years ago
Resolution: --- → FIXED
No longer blocks: validate
Status: RESOLVED → VERIFIED
QA Contact: imajes → daniel.bugmail
Got some problems with ampersands. Patch shortly.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Fixed to make validate
Assignee: endico → bugs.cameron
Attachment #131418 - Attachment is obsolete: true
Attachment #158117 - Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Attachment #233945 - Flags: review?(reed)
QA Contact: danielwang → www-mozilla-org
Comment on attachment 233945 [details] [diff] [review]
encode ampersands correctly

r=reed

Thanks!
Attachment #233945 - Flags: review?(reed) → review+
Checking in mozilla-org/html/foundation/donate.html;
/cvsroot/mozilla-org/html/foundation/donate.html,v  <--  donate.html
new revision: 1.37; previous revision: 1.36
done

Please verify once it reaches stage/production.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago → 18 years ago
Resolution: --- → FIXED
VERIFIED
Status: RESOLVED → VERIFIED
Product: mozilla.org → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: