21929 - Sidebar Customise dialog needs to use dialogOverlay for confirm buttons

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P3)

Description

[Henrik Gemal]

If you press customize.. in the side you see a new window where the Cancel and
Save buttons in the in wrong order.
The buttons should be like this:
Save - Cancel
and not
Cancel - Save

You always have the Ok button before the Cancel button!

Comment 1

[Steve Lamm]

Reassigning to german.
German, which way would you like to do it.
I could not find it in the spec.

Comment 2

[Henrik Gemal]

Could someone please check this in.
Diff output to correct this bug:

168a169,172
>     <titledbutton onclick="window.close()"
>        class="dialog push"
>        value="&sidebar.customize.cancel.label;" />
>     <spring flex="4%"/>
173,176d176
<     <spring flex="4%"/>
<     <titledbutton onclick="window.close()"
<        class="dialog push"
<        value="&sidebar.customize.cancel.label;" />

Comment 3

[Henrik Gemal]

Any chance for this BIG bug being fixed....!
It's a simple copy-paste source code change

Comment 4

[Paul MacQuiddy]

cc:ing [e-mail], making he can check it in

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

need to use dialogOverlay to get appropriate ordering on each platform. should 
be a simple fix... 

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

holding fix in tree for M15 open

Comment 7

[Paul MacQuiddy]

*** Bug 30040 has been marked as a duplicate of this bug. ***

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

done and done

Comment 9

[Paul MacQuiddy]

qa to shrir

Comment 10

[shrirang khanzode]

verif fixed on all builds (2000041706)