220424 - Need to distinguish between Web links and Help links in Mozilla Help

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, enhancement)

Description

[Daniel Wang]

something like
  a[href^="http://"]:after { content: url('web-link.gif'); }
in the Help css. and an image too

Comment 1

[Daniel Wang]

hmm... I thought Keller is the default owner of doc:user...

Comment 2

[R.J. Keller]

Maybe a border might be a better idea. or maybe a different background color?

Comment 3

[R.J. Keller]

Accepting.

Comment 4

[Daniel Wang]

border/background won't work because there's no universal color for outgoing
link or local link. Microsoft in its Help files use a little globe icon to
indicate Web resources, hence the css change request

Comment 5

[R.J. Keller]

So do you want a globe? Can you attach this image for me? thanks!

Comment 6

[R.J. Keller]

Daniel, you should file a bug for this at
http://firebirdhelp.mozdev.org/bugs.html under the Layout component.

Comment 7

[Daniel Wang]

Attachment: Weblink.svg

Comment 8

[Daniel Wang]

Attachment: Weblink.png (8 color black / white)

sorry for the delay. here's a black / white version of the globe, abut the
height of 12pt Arial. I tried various colours & stroke width and found thick
black lines to be the best.

Comment 9

[R.J. Keller]

Attachment: Patch

Comment 10

[[e-mail]]

Comment on attachment 133163 [details] [diff] [review]
Patch

>+a[href^="http://"]:after { content: url('chrome://communicator/skin/web-link.png'); }
web-links, surely?

Comment 11

[[e-mail]]

Comment on attachment 133163 [details] [diff] [review]
Patch

>+        skin/modern/communicator/web-links.png               (skin/web-links.png)
This would have been skin/modern/web-links.png if the skin had been the correct
place for the image. The image belongs in locale/en-US/images/.

>Index: skin/modern/help.css
This is the wrong file to patch, this is the chrome CSS, you want the content
CSS which is stored in locale. In fact you want both content CSS files for now.

>+a[href^="http://"]:after { content: url('chrome://communicator/skin/web-link.png'); }
So this will become chrome://help/locale/images/web-links.png (and why single
quotes? IIRC style is to use double quotes).

Comment 12

[[e-mail]]

Comment on attachment 132598 [details]
Weblink.png (8 color black / white)

Presumably we'll get sued if we colour it ;-)

Comment 13

[R.J. Keller]

> This would have been skin/modern/web-links.png if the skin had been the correct
> place for the image. The image belongs in locale/en-US/images/.

I think that the image should be skinned. (In case you haven't noticed, I'm big
on having the help doc CSS skinned ;)). If you don't want it, I'll take it out
but I thought it'd be neat to have everything skinned.

> This is the wrong file to patch, this is the chrome CSS, you want the content
> CSS which is stored in locale. In fact you want both content CSS files for now.

bah. wrong file. sorry! I'm thinking Firebird Help.

Comment 14

[R.J. Keller]

Attachment: Patch with Neil's comments.

Comment 15

[[e-mail]]

Comment on attachment 133526 [details] [diff] [review]
Patch with Neil's comments.

>+        locale/en-US/help/images/web-links.png             (locale/en-US/images/web-links.png)
>+a[href^="http://"]:after { content: url("chrome://help/locale/web-link.png"); }
>+a[href^="http://"]:after { content-url("chrome://help/locale/web-link.png"); }

These don't match up. The jar.mn calls the file /images/web-links.png but the
stylesheets use /web-link.png and also the second rule uses content-url instead
of content: url

Comment 16

[R.J. Keller]

Attachment: Patch v2.1

Comment 17

[[e-mail]]

Comment on attachment 133793 [details] [diff] [review]
Patch v2.1

>+        locale/en-US/help/images/web-links.png             (locale/en-US/images/web-links.png)
This line above refers to /images/, the two below don't.
>+a[href^="http://"]:after { content: url("chrome://help/locale/web-links.png"); }
>+a[href^="http://"]:after { content: url("chrome://help/locale/web-links.png"); }

Comment 18

[R.J. Keller]

Attachment: Patch v2.2

I apologize neil! I must've not seen your comment on that.

Comment 19

[[e-mail]]

Comment on attachment 133795 [details] [diff] [review]
Patch v2.2

Don't forget to cvs add -kb locale/en-US/images/web-links.png

Comment 20

[R.J. Keller]

Patch checked in.

Comment 21

[Daniel Wang]

v