221472 - Move current attach items to submenu of File

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Ian Neal]

In 4xp we used to have all the attach items as a submenu of File menu within the
compose window, similar to the Save As submenu.

Comment 1

[Ian Neal]

Attachment: Patch v0.1 that moves Attach items to new submenu

New Attach submenu that contains same choices at attach button on compose
window. Attach vCard is still in the options menu as well though.

Comment 2

[[e-mail]]

Comment on attachment 132969 [details] [diff] [review]
Patch v0.1 that moves Attach items to new submenu

Please clean up the strings a bit.

Comment 3

[Ian Neal]

Attachment: Patch v0.2 that creates new Attach submenu and does some tidy up

Moves attach choices from file into new Attach submenu of file and also adds
the vCard attachmenu to that submenu as it was under NS4.x. String names have
been cleaned up and redundant ones removed.

Comment 4

[[e-mail]]

Comment on attachment 132969 [details] [diff] [review]
Patch v0.1 that moves Attach items to new submenu

Oops, that seems to have made things worse - I forgot about the context menu
:-[

Comment 5

[Ian Neal]

Attachment: Patch v0.3 - creates new Attach submenu, attach page to bucket and general clean up

Revised patch that adds Attach submenu to File menu, adds attach web page to
attachment bucket context menu and does some general tidy up of string names.

Comment 6

[[e-mail]]

Comment on attachment 133076 [details] [diff] [review]
Patch v0.3 - creates new Attach submenu, attach page to bucket and general clean up

Although if you insist...

>+<!ENTITY attachCmd.label "Attach">
>+<!ENTITY attachCmd.accesskey "t">
I think these should be attachMenu (SaveAs incorrectly uses Cmd but Priority,
returnReceipt, outputFormat and fileHere use Menu)

>+<!ENTITY attachFile.label "File(s)...">
>+<!ENTITY attachFile.key "">
>+<!ENTITY attachFile.accesskey "F">
>+<!ENTITY attachPage.label "Web Page...">
>+<!ENTITY attachPage.accesskey "W">
>+<!--LOCALIZATION NOTE attachVCard.label Don't translate the term 'vCard' -->
>+<!ENTITY attachVCard.label "Personal Card (vCard)">
>+<!ENTITY attachVCard.accesskey "P">
I would have said attachXXXCmd.* except this conflicts with the options version
of the vCard which should in theory also be attachVCardCmd as the original l10n
note suggests.

>-<!--LOCALIZATION NOTE attachVCardCmd.label Don't translate the term 'vCard' -->
>+<!--LOCALIZATION NOTE attachVCardMenu.label Don't translate the term 'vCard' -->
> <!ENTITY attachVCardMenu.label "Attach Personal Card (vCard)">
> <!ENTITY attachVCardMenu.accesskey "v">
Sigh. Maybe just attachVCard.*?

> <!ENTITY delete.label "Delete">
> <!ENTITY delete.accesskey "D">
> <!ENTITY selectAll.label "Select All">
> <!ENTITY selectAll.accesskey "A">
>+<!ENTITY attachFileBucket.label "Attach File(s)...">
>+<!ENTITY attachFileBucket.accesskey "F">
>+<!ENTITY attachPageBucket.label "Attach Web Page...">
>+<!ENTITY attachPageBucket.accesskey "W">
Drop Bucket, the other context items don't use it.

Comment 7

[Ian Neal]

Attachment: Patch v0.3a - gives Attach submenu, attach page in bucket and string clean up

Taking on board Neil's comments

Comment 8

[Ian Neal]

Taking from [e-mail] (Seth Spitzer)

Comment 9

[Ian Neal]

Accepting

Comment 10

[Ian Neal]

Comment on attachment 133125 [details] [diff] [review]
Patch v0.3a - gives Attach submenu, attach page in bucket and string clean up

Carrying forward r=

Comment 11

[David :Bienvenu]

Comment on attachment 133125 [details] [diff] [review]
Patch v0.3a - gives Attach submenu, attach page in bucket and string clean up

I'm not crazy about having this in three places, but it is consistent with 4.x,
I guess...removing it from the options menu is a possibility, I think.

Comment 12

[[e-mail]]

Fix checked in.

Comment 13

[Scott MacGregor]

I agree with David. I think we should remove the vCard option from the Options
menu. I'm doing that in thunderbird FWIW. 

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2006-01-06-09 of SeaMonkey trunk on Windows XP.