221995 - Coding error in jsObject.js

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[[e-mail]]

Comment 1

[[e-mail]]

Attachment: Proposed patch

So, was kids supposed to be a node or a node list?

Comment 2

[Alex Vincent [:WeirdAl]]

Comment on attachment 133189 [details] [diff] [review]
Proposed patch

>   openTreeItem: function(aItem)
>   {
>-    var kids = aItem.getElementsByTagName("treechildren");
>-    if (kids.length == 0) {
>-      kids = document.createElement("treechildren");
>+    var treechildren = aItem.getElementsByTagName("treechildren").item(0);
>+    if (!treechildren) {
>+      treechildren = document.createElement("treechildren");

A rose by any other name... the intent of the kids argument is pretty clear
here, I think.

>       aItem.appendChild(kids);

And if you really want this, this argument needs to change too, or you get an
instant strict JS warning and a regression, at the very least.

>     }
>     
>-    this.buildPropertyTree(kids, aItem.__JSValue__);
>+    this.buildPropertyTree(treechildren, aItem.__JSValue__);

Ditto on the rose.

>   },
>   
>   onCreateContext: function(aPopup)
>@@ -276,7 +276,7 @@ function getSelectedItem()
> {
>   var tree = document.getElementById("treeJSObject");
>   if (tree.view.selection.count)
>-    return tree.contentView.getItemAtIndex(tree.curentIndex);
>+    return tree.view.getItemAtIndex(tree.curentIndex);

tree.currentIndex

Finally, I'm working on revising my patch to bug 193942, where half of the
jsObject.js file is rewritten.	The openTreeItem() function will be obsoleted
and removed by my patch.  (I know it's taking me forever, but I think you
should consider the revisions.)

Comment 3

[[e-mail]]

As you noticed I attached the wrong diff...

Anyway IMHO "kids" is an inappropriate name for an element.

Comment 4

[[e-mail]]

*** Bug 317322 has been marked as a duplicate of this bug. ***

Comment 5

[[e-mail]]

Attachment: Corrected patch

Comment 6

[[e-mail]]

Comment on attachment 203931 [details] [diff] [review]
Corrected patch

Given as there's no moa? flag in bugzilla...

Comment 7

[[e-mail]]

Fix checked in.

Comment 8

[[e-mail]]

Oops, fix is wrong, coding error hid logic error.

Comment 9

[[e-mail]]

Attachment: Logic fix

Comment 10

[[e-mail]]

Fix for logic error hidden by coding error checked in.