222209 - nsReadLine.h not friendly with DOS-style text file

Status: VERIFIED INVALID

(Core :: Networking: File, defect)

Description

[Daniel Wang]

it appears NS_ReadLine() will always skip any line with \r\n or \n\r

This function is used by mozilla/netwerk/cookie/src/nsCookieService.cpp
nsCookieService::Read() and the bug causes it to import cookie file exported by
MSIE incorrectly.

Comment 1

[Daniel Wang]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Um... The code was designed to handle \r\n line endings and was tested on such
(as well as \n\r, \r, and \n) before it was checked into the tree.  When we hit
the \r we set eolStarted; when we hit the following \n we return from the
function (since we reached end of line).  That's correct.

Your change would make us not return at the end of the line, which would be wrong...

So why does this change make things better, exactly?

Comment 3

[Daniel Wang]

sorry, you are right. The code does work. -> invalid

Comment 4

[benc]

v.