Closed Bug 22329 Opened 25 years ago Closed 25 years ago

[dogfood][regression] The second time you close a msg compose window crash the app

Categories

(MailNews Core :: Composition, defect, P3)

Product:
MailNews Core
Component:
Composition
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

(Whiteboard: [PDT+]) 

I get this crash with debug build from today either on Mac or Windows

steps:
1) Start Mozilla
2) Start Messenger
3) Click "New Msg"
4) Close the compose window (click in close box)
5) Click "New Msg"
6) Close the compose window (click in close box)
7) --> crash in nsMsgCompose::~nsMsgCompose because m_editor has been already
destroyed.

So far, I found that the first time you open a compose window and then close it,
we are missing a release on nsMsgCompose therefore the destructor is never
called. Also we set twice the editor (nsMsgCompose:SetEditor !! to be verified).
The second time the object his correctly destroyed but for some reason editor is
destroyed before nsMsgCompose which try to unregister a document state listener
in editor which cause the crash.
Status: NEW → ASSIGNED
Summary: [dogfood][regression] The second time you close a msg compose window crash the app → [dogfood][regression] The second time you close a msg compose window crash the app
Target Milestone: M13
correction, the editor is set correctly only once.
Whiteboard: [PDT+]
Marking PDT+
Whiteboard: [PDT+] → [PDT+] 12/23, I've already a fix for the crash part but not for the leak.
I have a fix for the crash but I still not understand why we are leaking the
first time.
Whiteboard: [PDT+] 12/23, I've already a fix for the crash part but not for the leak. → [PDT+] 12/23, need a code review...
Ok, The leak is see the first time you close the window is due to the well knonw bug 21056.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Whiteboard: [PDT+] 12/23, need a code review... → [PDT+]
Crash fixed and checked in.
QA Contact: lchiang → fenella
fenella - can you verify? Thanks.
Status: RESOLVED → VERIFIED
Linux Redhat 6.0 (2000-01-04-08 M13)
Win_nt 4.0 (2000-01-04-08 M13)
Mac (2000-01-04-08 M13)
This problem has been fixed.
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.