224886 - Support http_proxy

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Tinderbox3, defect)

Description

[Christian Reis]

Tinderclient currently has a problem when behing an http_proxy. 
Turning this on is trivial with LWP; basically calling

    $this->{UA}->env_proxy()

in tinderclient.pl's initialization. Sound correct?

Comment 1

[John Keiser (jkeiser)]

Sounds like it's probably right.  I suggest making this a config variable, so
that there are no changes to the admin interface.  (By this I mean the machine
config, that set of name/value textboxes.)  Basically the only things to change
would be the default setup (so that people know this variable exists) and the
client (to grab the variable from the server and call that method).  Maybe
http_proxy=blah?

Comment 2

[Christian Reis]

You can just use the env_proxy() call with no parameters to grab this from the
standard environment variable http_proxy. Something like:

+kernel_tinderclient_patched/tinderclient.pl
--- kernel_tinderclient/tinderclient.pl 2003-11-06 21:55:26.000000000 -0800
+++ kernel_tinderclient_patched/tinderclient.pl 2003-12-11 10:28:06.000000000 -0800
@@ -206,6 +206,7 @@
   # The user agent object
   $this->{UA} = new LWP::UserAgent;
   $this->{UA}->agent("TinderboxClient/" . $TinderClient::PROTOCOL_VERSION);
+  $this->{UA}->env_proxy();
   # the tinderclient.log out
   $this->{LOG_OUT} = undef;
   # the tinderclient.log in

Comment 3

[Ricardo Almeida]

Well, it's 2010 and it still doesn't work :(

http_proxy suport would be greatly appreciated.

Comment 4

[Stanislav GE]

I'm totally agree.
It would be nice if Firefox use http_proxy, ftp_proxy and https_proxy settings while "Use system proxy settings" are enabled.

Comment 5

[Kyle Guinn]

(In reply to Stanislav GE from comment #4)
> I'm totally agree.
> It would be nice if Firefox use http_proxy, ftp_proxy and https_proxy
> settings while "Use system proxy settings" are enabled.

I think bug 66057 was supposed to fix this, but apparently it didn't.

Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120830 Firefox/15.0 SeaMonkey/2.12

Comment 6

[whelderwheels613]

Well, its 2017 and it *still* doesn't work.

Comment 7

[tarsis.azevedo]

Well, its 2018 and it *still* doesn't work.

Comment 8

[sebboh (use needinfo)]

At least it's still 2018.

I'm a novice.. I don't know what 'tinderbox' is.

But, here's what I know.

As you can see in https://searchfox.org/mozilla-central/source/toolkit/system/unixproxy/nsUnixSystemProxySettings.cpp#175 , the Firefox routine that checks the environment variables for proxy settings doesn't know how to set SOCKS proxies.

As for the comment: 

    // Is there a way to specify "socks://" or something in these environment
    // variables? I can't find any documentation.

...I propose to follow curl's lead: https://curl.haxx.se/libcurl/c/CURLOPT_PROXY.html

I hope this helps.

Faithfully yours,
--sebboh

Comment 9

[Sylvestre Ledru [:Sylvestre]]

I think there are some confusions in this bug.
This bug is about tinderbox, the old build platform for Firefox.
If this is an issue with Firefox, please open a new bug.