226249 - buglist.cgi warning (use uninitialized value) line 97 for no ctype defined

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Vlad Dascalu]

If we don't have a ctype CGI param defined, then I get in the server error log:

[Wed Nov 19 22:27:12 2003] [error] [client 127.0.0.1] stderr from script: [Wed
Nov 19 22:27:12 2003] buglist.cgi: Use of uninitialized value in string eq at
/var/www/html/bugzilla/buglist.cgi line 97.

Comment 1

[Vlad Dascalu]

Attachment: Patch

Comment 2

[Vlad Dascalu]

CC-ing default component owner and r? requstee.

Comment 3

[Christian Reis]

Comment on attachment 135944 [details] [diff] [review]
Patch

>Index: buglist.cgi
>-if ($::FORM{'ctype'} eq "js") {
>-    Bugzilla->logout();
>+if (defined $::FORM{'ctype'}) {
>+    if ($::FORM{'ctype'} eq "js") {
>+        Bugzilla->logout();

There's this great operator -- && -- and it's very useful for cass like this
:-)

Comment 4

[Dave Miller [:justdave]]

*** Bug 226251 has been marked as a duplicate of this bug. ***

Comment 5

[Dave Miller [:justdave]]

CCing Gerv because he caused this ;)

Comment 6

[Vlad Dascalu]

Attachment: Version2

It can exists without being defined but as justdave and kiko enlighted me, it's
guaranteed to have a value in case it exists so using "exists" instead of
"defined" should work.

Comment 7

[Vlad Dascalu]

Attachment: Ver 3

Comment 8

[Gervase Markham [:gerv]]

Oops. Sorry :-) But it did fix the security hole.

Gerv

Comment 9

[Vlad Dascalu]

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.239; previous revision: 1.238
done

Comment 10

[Frédéric Buclin]

*** Bug 235656 has been marked as a duplicate of this bug. ***