Closed
Bug 226361
Opened 21 years ago
Closed 15 years ago
Tabindex not working properly on XHTML Anchor testcase
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: pkwarren, Assigned: zhayupeng)
References
()
Details
Attachments
(2 files, 1 obsolete file)
|
1.23 KB,
patch
|
aaronlev
:
review+
bryner
:
superreview-
mkaply
:
approval1.7+
|
Details | Diff | Splinter Review |
|
4.70 KB,
patch
|
Details | Diff | Splinter Review |
In the specified URL, the tabindex works properly the first time tabbing through the elements, but the second time through, it seems to get confused and skip the 3rd and 5h links. The testcase works properly in IE (after saving the file with a .html extension). Expected behavior: Tabbing goes from 3rd link -> 5th link -> 1st link -> 2nd link -> 4th link -> url bar and back to the 3rd link. Actual behavior: Tabbing goes from 3rd link -> 5th link -> 1st link -> 2nd link -> 4th link -> url bar and back to the 1st link, skipping 3rd and 5th links.
I think this bug was origianlly introduced by the fix of bug 130447 (http://bugzilla.mozilla.org/attachment.cgi?id=75086&action=view), we should not do that when the current selection is root content. See http://lxr.mozilla.org/seamonkey/source/content/events/src/nsEventStateManager.cpp#3097
Comment on attachment 136161 [details] [diff] [review] proposed patch Aaron, what do you think?
Attachment #136161 -
Flags: review?(aaronlev5)
|
||
Comment 3•20 years ago
|
||
Comment on attachment 136161 [details] [diff] [review] proposed patch r=aaronl
Attachment #136161 -
Flags: review?(aaronleventhal) → review+
|
||
Comment 4•20 years ago
|
||
Comment on attachment 136161 [details] [diff] [review] proposed patch a=mkaply when you get an sr
Attachment #136161 -
Flags: approval1.7+
Attachment #136161 -
Flags: superreview?(bryner)
|
||
Comment 5•20 years ago
|
||
Comment on attachment 136161 [details] [diff] [review] proposed patch After reading the DOM Range spec, it seems like this would break the case where the selection start or end is between two immediate children of the root node. I don't think this can happen in legal HTML or XHTML, but it could presumably happen in other markup languages. I wonder if this is related to the testcase having a <p> node directly under the <html> instead of under the <body>.
I saved the test case locally and found an interesting thing: if I changed the file suffix to html, the bug will be gone; if I still use the .xml suffix, the bug is reproducible no matter where the <p> tag is (under <html> or under <body>).
|
||
Comment 7•20 years ago
|
||
This is WFM on Gecko/20040302 Firefox on Debian, btw.
No longer blocks: badtests
|
|
||
Comment 8•20 years ago
|
||
Comment on attachment 136161 [details] [diff] [review] proposed patch minusing, this doesn't seem right.
Attachment #136161 -
Flags: superreview?(bryner) → superreview-
|
||
Comment 9•15 years ago
|
||
Works fine in Firefox 20090721 nightly on Linux. Probably fixed by the new focus manager (bug 178324). I'll resolve the bug WFM and push a regression test as soon as it clears all platforms on TryServer.
|
|
||
Comment 10•15 years ago
|
||
|
|
||
Comment 11•15 years ago
|
||
Attachment #390505 -
Attachment is obsolete: true
|
|
||
Comment 12•15 years ago
|
||
Pushed the test: http://hg.mozilla.org/mozilla-central/rev/3c87acfd4ca4 -> WORKSFORME
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → WORKSFORME
|
||
Updated•5 years ago
|
Component: Keyboard: Navigation → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•