Closed Bug 227623 Opened 21 years ago Closed 21 years ago

[FIXr]Scripts panel scripts broken

Categories

(SeaMonkey :: Preferences, defect, P1)

Product:
SeaMonkey
Component:
Preferences
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.6final

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Patch
1.57 KB, patch
neil
: review+
alecf
: superreview+
dbaron
: approval1.6b+
Details | Diff | Splinter Review 
From bug 227612:

Disabling JS for Navigator didn´t gray out the JS-settings

"That got broken by the patch to bug 181973
-- the Startup() function for that pref panel has a JS error."
Attached patch Patch — — Splinter Review 
The key here is the removal of the stray '}'
Attachment #136919 - Flags: superreview?(alecf)
Attachment #136919 - Flags: review?(neil.parkwaycc.co.uk)
Priority: -- → P1
Summary: Scripts panel scripts broken → [FIX]Scripts panel scripts broken
Target Milestone: --- → mozilla1.6final
Comment on attachment 136919 [details] [diff] [review]
Patch

Doh :-[
Attachment #136919 - Flags: review?(neil.parkwaycc.co.uk) → review+
Would be good to not ship 1.6b with this...
Flags: blocking1.6b?
Add semicolon after
document.getElementById("pluginPreferences")
Comment on attachment 136919 [details] [diff] [review]
Patch

sr=alecf
the semicolon would be nice, to not confuse emacs
Attachment #136919 - Flags: superreview?(alecf) → superreview+
Comment on attachment 136919 [details] [diff] [review]
Patch

Could this please be approved for 1.6b?  Simple removal of stray '}' char that
makes this panel actually work...
Attachment #136919 - Flags: approval1.6b?
Summary: [FIX]Scripts panel scripts broken → [FIXr]Scripts panel scripts broken
Attachment #136919 - Flags: approval1.6b? → approval1.6b+
Checked in for 1.6b.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
For the record:
Comment 7 check in includes both the patch and comment 4 suggestion :-)
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: