227930 - RFE: Update Calendar to use Qute style icons

Status: RESOLVED WONTFIX

(Calendar :: Sunbird Only, enhancement)

Description

[Kenneth]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030917 Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030917 Firebird/0.6.1+

Calendar should evolve to using the style and techniques used in the *Bird
implementations, including a new "Qute" style theme and methodology.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Mostafa Hosseini]

Hi Kenneth,
So I guess the plan would be to provide a new skin directory with all the
appropriate files.

Comment 2

[Kenneth]

Attachment: calendar.css (modified lines - 49-331; 398-445)

Comment 3

[Kenneth]

Attachment: calendar.xul - (modified lines 415-450)

Comment 4

[Kenneth]

Attachment: monthView.xul (modified lines 76, 108)

Comment 5

[Kenneth]

Attachment: calendar-toolbar.png (created directory "icons" in classic for this)

Comment 6

[Kenneth]

Attachment: calendar-toolbar-small.png (created directory "icons" in classic for this)

Comment 7

[Kenneth]

Attachment: prevnextarrow.png (created directory "icons" in classic for this)

Comment 8

[Kenneth]

This is my first attempt to properly use Bugzilla, so I may need some coaching
as I use the system.  Basically all of the attached files (posted 2003-12-09)
are modifications to begin converting Calendar to the "Qute" style.  Eventually,
ideally, all icons will go into the "icons" directory and the structure will
become more like TB and FB.

The icons here are mostly from the existing set, with some existing ones from
Qute pulled from the browser.  Both regular sized and small toolbar icons are
included, although I do not know how to add the toolbar customization to choose
small icons.

Also, ideally the modified lines in calendar.css would go in an external file
(primaryToolbar.css) and be imported into calendar.css.  But again, I'm not
knowledgable enough to do this just yet.

Updated graphical icons for the Qute style to come as I'm able to do them, or I
would encourage someone else with further experience in icon creation to step up
to help.

Modified files:
calendar.css
monthView.xul
calendar.xul

Deleted:
btn1.gif
btnwm1.gif
btn1.png
prevnextarrow.png

Created:
icons/
icons/calendar-toolbar.png
icons/calendar-toolbar-small.png
icons/prevnextarrow.png

Comment 9

[David Fraser]

Attachment: patches to calendar xul files

this is a patch that corresponds to the changes made in calendar.xul and
monthView.xul

Comment 10

[Mostafa Hosseini]

Comment on attachment 137126 [details] [diff] [review]
patches to calendar xul files

Please provide patches using cvs code, otherwise they won't have any use.

Comment 11

[David Fraser]

Attachment: changes to calendar.css

these are the changes to calendar/resources/skin/classic/calendar.css

Comment 12

[Mostafa Hosseini]

Comment on attachment 137127 [details] [diff] [review]
changes to calendar.css

Please provide patches using cvs code, otherwise they won't have any use

Comment 13

[David Fraser]

Attachment: patches to calendar xul files

this is a patch that corresponds to the changes made in calendar.xul and
monthView.xul, on latest CVS

Comment 14

[David Fraser]

Attachment: changes to calendar.css

these are the changes to calendar/resources/skin/classic/calendar.css (from
latest cvs)

Comment 15

[David Fraser]

Sorry, patches were against MOZILLA_1_5_BRANCH. (I did a cvs update but didn't
realise I had a tag), have updated...

Comment 16

[Mostafa Hosseini]

kenneth: Any reason you changed the "id"s of the icons? If not can you just use
the old names to minimize the changes?

Comment 17

[Mostafa Hosseini]

Kenneth is not getting emailed as comments are added. Ccing him to see if it works.

Comment 18

[Mostafa Hosseini]

kenneth: Are you using the latest code from CVS? Please do so, because your
proposed changes are backing out some fixes recently made to the code.
Example:

 .week-view-event-class[eventselected="true"]
 {
-   background-color     :  #D5E3F2;  
-   border	        : 2px solid #990000;
+   background-color  : #D5E3F2;
+	border				: 1px solid #003366;
 }

which was fixed for bug 210236 here( see bottom ):
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=calendar.css&branch=&root=/cvsroot&subdir=mozilla/calendar/resources/skin/classic&command=DIFF_FRAMESET&rev1=1.43&rev2=1.44

Comment 19

[Kenneth]

Honestly I wasn't using the code from the CVS.  I've yet a great deal to learn 
about the process and am reading the Hacking Mozilla section of the site now.  
Originally this started out as just my tweaking Eric Belhaire's Calendar for 
Thunderbird code.

Thanks for the advice,
Kenneth

Comment 20

[Peter Lairo]

The rabbit hole is deep, but also very rewarding... ;)

Comment 21

[Kenneth]

Attachment: Updated calendar.css, modified from file from CVS

I've made my changes to the file from the CVS.	Also, to address the comment
about why I changed the button names, it was to remain consistent with the
style in which Thunderbird/Firebird are done.  It could easily be changed back
if this isn't kosher with folks.

Thanks,
Kenneth

Comment 22

[Kenneth]

Attachment: Calendar.xul, modified from the CVS

Comment 23

[David Fraser]

Attachment: patches to calendar.xul

updated patch for calendar.xul based on latest CVS

Comment 24

[David Fraser]

Attachment: changes to calendar.css

changes to calendar.css updated from latest CVS. Does not include name changes
any more

Comment 25

[David Fraser]

Kenneth, should the monthView.xul attachment be obsoleted, seeing as those
changes aren't included in calendar.css anymore?

Comment 26

[Mostafa Hosseini]

Question: Where are the "small" toolbar icons supposed to show up? Applying the
patch I get the big Qute icons for the main toolbar but I don't know where to
look for the small ones.
Also I have problems with the prev and next arrows ( they all show up ). It
might just be me though.

Comment 27

[Kenneth]

Comment on attachment 137116 [details]
monthView.xul (modified lines 76, 108)

This is obsolete as the month change has gone back to the old method

Comment 28

[Kenneth]

Responding to #26... this is for a later implementation of the customazible 
toolbar used in Firebird and Thunderbird.  I have no idea at this stage how it 
is done, but ideally it would include this similar functionality at some 
point.  That way we have that much work out of the way.

Ken

Comment 29

[Chris Cook]

Sipaq on the Mozillazine forums has requested work to be done on revising the
classic theme for Sunbird. I am doing this work (with the help of a graphic artist).

With the theme changes for Firefox and Thunderbird, the theme for Sunbird will
not be using Qute style graphics. Therefore, should this bug be WONTFIXed and a
new bug be created for the theme revision? I don't see an existing bug for the
theme work but I have some questions and would like some guidance.

Comment 30

[Simon Paquet [:sipaq]]

-> WONTFIX
Like Chris said, we're looking for a totally new theme, though that may even be
a    Qute-like theme if Mostafah says so. 

Chris please open a new bug for the new theme contest and please CC me on that bug.

Comment 31

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!